pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Parallel worker hangs while handling errors.
Date: Fri, 07 Aug 2020 14:00:34 -0400
Message-ID: <2764320.1596823234@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+Tgmob0RD+yB_PPy3HAxoXz71-s8JSX3uzXqhZZWO8WKGOHVg@mail.gmail.com>
References: <CALDaNm1d1hHPZUg3xU4XjtWBOLCrA+-2cJcLpw-cePZ=GgDVfA@mail.gmail.com>
	<CALj2ACVBLox7LvCKpWd7k-kubwrmeRFjZRTrnGHN6RZQgG4cxw@mail.gmail.com>
	<CALDaNm2g5GgBpzGgdwhFgxD=ur42O+Fh+prp-xiyHp+feB+q=w@mail.gmail.com>
	<CALj2ACX=iLQyY9-htQvvXG1ER_6wM5DELy8k5quA+gRLHDSxDA@mail.gmail.com>
	<CALDaNm04E=fbixNSqEeb4PWGdeYY26OZ-4bXNayKR2QoV6i=Yg@mail.gmail.com>
	<CALj2ACX9eUkKy3UrAv+bDx3QYdS8RLBp8Rfq8FSQHOmrXtGe1Q@mail.gmail.com>
	<CALDaNm1O1mauSawnz-He3x6PPy91H_GMqWc9gsBezejm6QuZ+w@mail.gmail.com>
	<CALj2ACWB9P6ocrzTQDTB7wT3gdtc1m7fntnPpBbNb3ZjOGiMrQ@mail.gmail.com>
	<CA+TgmoZAya0STWjtHdhr1FgeSV4EtLf69DkYFSG4ZjbHPLe7gw@mail.gmail.com>
	<CALj2ACXEVxRrmrpsZxLEMKtRQdqOWQWwm=zRjPyO6_uU1KZLnQ@mail.gmail.com>
	<CA+TgmobZxfjhDTMQPE-2MgEvBKOKLhqh_qco6EgV-mDXMP77Uw@mail.gmail.com>
	<2754818.1596814605@sss.pgh.pa.us>
	<CA+TgmoactknFJX--rK07OPmhh_eucFZfj7b_HrtGCWS3wNaDBw@mail.gmail.com>
	<2758174.1596819361@sss.pgh.pa.us>
	<CA+Tgmob0RD+yB_PPy3HAxoXz71-s8JSX3uzXqhZZWO8WKGOHVg@mail.gmail.com>

Robert Haas <robertmhaas@gmail.com> writes:
> On Fri, Aug 7, 2020 at 12:56 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> That SETMASK call will certainly unblock SIGQUIT, so I don't see what
>> your point is.

> I can't figure out if you're trolling me here or what. It's true that
> the PG_SETMASK() call will certainly unblock SIGQUIT, but that would
> also be true if the sigdelset() call were absent.

The point of the sigdelset is that if somewhere later on, we install
the BlockSig mask, then SIGQUIT will remain unblocked.  You asserted
upthread that noplace in these processes ever does so; maybe that's
true today, or maybe not, but the intent of this code is that *once
we get through initialization* SIGQUIT will remain unblocked.

I'll concede that it's not 100% clear whether or not these processes
need to re-block SIGQUIT during error recovery.  I repeat, though,
that I'm disinclined to change that without some evidence that there's
actually a problem with the way it works now.

			regards, tom lane





view thread (24+ messages)  latest in thread

Message-ID: <2764320.1596823234@sss.pgh.pa.us>
Permalink:  ../2764320.1596823234@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2764320.1596823234@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, bharath.rupireddyforpostgres@gmail.com
  Subject: Re: Parallel worker hangs while handling errors.
  In-Reply-To: <2764320.1596823234@sss.pgh.pa.us>
  References: <CALDaNm1d1hHPZUg3xU4XjtWBOLCrA+-2cJcLpw-cePZ=GgDVfA@mail.gmail.com> <CALDaNm2g5GgBpzGgdwhFgxD=ur42O+Fh+prp-xiyHp+feB+q=w@mail.gmail.com> <CALj2ACX=iLQyY9-htQvvXG1ER_6wM5DELy8k5quA+gRLHDSxDA@mail.gmail.com> <CALDaNm04E=fbixNSqEeb4PWGdeYY26OZ-4bXNayKR2QoV6i=Yg@mail.gmail.com> <CALj2ACX9eUkKy3UrAv+bDx3QYdS8RLBp8Rfq8FSQHOmrXtGe1Q@mail.gmail.com> <CALDaNm1O1mauSawnz-He3x6PPy91H_GMqWc9gsBezejm6QuZ+w@mail.gmail.com> <CALj2ACWB9P6ocrzTQDTB7wT3gdtc1m7fntnPpBbNb3ZjOGiMrQ@mail.gmail.com> <CA+TgmoZAya0STWjtHdhr1FgeSV4EtLf69DkYFSG4ZjbHPLe7gw@mail.gmail.com> <CALj2ACXEVxRrmrpsZxLEMKtRQdqOWQWwm=zRjPyO6_uU1KZLnQ@mail.gmail.com> <CA+TgmobZxfjhDTMQPE-2MgEvBKOKLhqh_qco6EgV-mDXMP77Uw@mail.gmail.com> <2754818.1596814605@sss.pgh.pa.us> <CA+TgmoactknFJX--rK07OPmhh_eucFZfj7b_HrtGCWS3wNaDBw@mail.gmail.com> <2758174.1596819361@sss.pgh.pa.us> <CA+Tgmob0RD+yB_PPy3HAxoXz71-s8JSX3uzXqhZZWO8WKGOHVg@mail.gmail.com> <2764320.1596823234@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox