pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Noah Misch <noah@leadboat.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Fixing WAL instability in various TAP tests
Date: Mon, 27 Sep 2021 16:19:27 -0400
Message-ID: <2769443.1632773967@sss.pgh.pa.us> (raw)
In-Reply-To: <C1D227C2-C271-4310-8C85-C5368C298622@enterprisedb.com>
References: <32A1FDD1-9C7B-43B1-B3EE-49198DD3F887@enterprisedb.com>
	<20210925052151.GA4082552@rfd.leadboat.com>
	<2E9D28A3-1B54-446B-AC12-3BF86A2B522A@enterprisedb.com>
	<2502590.1632579467@sss.pgh.pa.us>
	<2B4C64CF-EE3F-474B-9685-6A927E5E49AE@enterprisedb.com>
	<20210925160039.GA4134968@rfd.leadboat.com>
	<193AC968-C348-4D81-88BC-384560F87500@enterprisedb.com>
	<C1D227C2-C271-4310-8C85-C5368C298622@enterprisedb.com>

Mark Dilger <mark.dilger@enterprisedb.com> writes:
> Here is a patch set, one patch per test.  The third patch enables its test in the Makefile, which is commented as having been disabled due to the test being unstable in the build farm.  Re-enabling the test might be wrong, since the instability might not have been due to WAL being recycled early.  I didn't find enough history about why that test was disabled, so trying it in the build farm again is the best I can suggest.  Maybe somebody else on this list knows more?

Digging in the archives where the commit points, I find

https://www.postgresql.org/message-id/flat/20181126025125.GH1776%40paquier.xyz

which says there was an unexpected result on my animal longfin.
I tried the same thing (i.e., re-enable bloom's TAP test) on my laptop
just now, and it passed fine.  The laptop is not exactly the same
as longfin was in 2018, but it ought to be close enough.  Not sure
what to make of that --- maybe the failure is only intermittent,
or else we fixed the underlying issue since then.

I'm a little inclined to re-enable the test without your other
changes, just to see what happens.

			regards, tom lane





view thread (25+ messages)  latest in thread

Message-ID: <2769443.1632773967@sss.pgh.pa.us>
Permalink:  ../2769443.1632773967@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2769443.1632773967@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, mark.dilger@enterprisedb.com, noah@leadboat.com
  Subject: Re: Fixing WAL instability in various TAP tests
  In-Reply-To: <2769443.1632773967@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox