pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: James Hilliard <james.hilliard1@gmail.com>
Cc: David Steele <david@pgmasters.net>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Sergey Shinderuk <s.shinderuk@postgrespro.ru>
Subject: Re: [PATCH v3 1/1] Fix detection of preadv/pwritev support for OSX.
Date: Tue, 30 Mar 2021 01:58:37 -0400
Message-ID: <2781003.1617083917@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+hUKGJP4nCdi1jKQ5rYJpNwMKVskOA6k=yW36K254ok_6_AZg@mail.gmail.com>
References: <20210122193230.25295-1-james.hilliard1@gmail.com>
	<CADvTj4pZy=BNW00dtOA5LTBDiSMo2bXaea_gh8UQSLOsn+mRNQ@mail.gmail.com>
	<ef0dbb86-511d-94a0-de54-ce526c505a4a@pgmasters.net>
	<CADvTj4qwmJgqWB5zStrPAxRL2DsPThtwOubAAUPUSh0XSY0JTw@mail.gmail.com>
	<CA+hUKGJ9Fsy3Hdgs8BpgBd+J06qo9=4LdGBK5sWxzBt08fENgg@mail.gmail.com>
	<CADvTj4oSfH8qN-v_W1ydbA5uJkChxCj8RntwsH-EStytygtALg@mail.gmail.com>
	<CA+hUKGJP4nCdi1jKQ5rYJpNwMKVskOA6k=yW36K254ok_6_AZg@mail.gmail.com>

Thomas Munro <thomas.munro@gmail.com> writes:
> I'll move it when committing.  I'll let this patch sit for another day
> to see if any other objections show up.

FWIW, I remain fairly strongly against this, precisely because of the
point that it requires us to start using a randomly different
feature-probing technology anytime Apple decides that they're going to
implement some standard API that they didn't before.  Even if it works
everywhere for preadv/pwritev (which we won't know in advance of
buildfarm testing, and maybe not then, since detection failures will
probably be silent), it seems likely that we'll hit some case in the
future where this interacts badly with some other platform's weirdness.
We haven't claimed in the past to support MACOSX_DEPLOYMENT_TARGET,
and I'm not sure we should start now.  How many people actually care
about that?

			regards, tom lane





view thread (25+ messages)  latest in thread

Message-ID: <2781003.1617083917@sss.pgh.pa.us>
Permalink:  ../2781003.1617083917@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2781003.1617083917@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, thomas.munro@gmail.com, james.hilliard1@gmail.com, david@pgmasters.net, pgsql-hackers@lists.postgresql.org, s.shinderuk@postgrespro.ru
  Subject: Re: [PATCH v3 1/1] Fix detection of preadv/pwritev support for OSX.
  In-Reply-To: <2781003.1617083917@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox