From: David Steele <david@pgmasters.net>
To: James Hilliard <james.hilliard1@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Cc: Sergey Shinderuk <s.shinderuk@postgrespro.ru>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: [PATCH v3 1/1] Fix detection of preadv/pwritev support for OSX.
Date: Mon, 29 Mar 2021 09:52:10 -0400
Message-ID: <ef0dbb86-511d-94a0-de54-ce526c505a4a@pgmasters.net> (raw)
In-Reply-To: <CADvTj4pZy=BNW00dtOA5LTBDiSMo2bXaea_gh8UQSLOsn+mRNQ@mail.gmail.com>
References: <20210122193230.25295-1-james.hilliard1@gmail.com>
<CADvTj4pZy=BNW00dtOA5LTBDiSMo2bXaea_gh8UQSLOsn+mRNQ@mail.gmail.com>
Hi James,
On 1/31/21 1:59 AM, James Hilliard wrote:
> On Fri, Jan 22, 2021 at 12:32 PM James Hilliard
> <james.hilliard1@gmail.com> wrote:
>>
>> Fixes:
>> gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -Wno-unused-command-line-argument -O2 -I../../../../src/include -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk -c -o fd.o fd.c
>> fd.c:3661:10: warning: 'pwritev' is only available on macOS 11.0 or newer [-Wunguarded-availability-new]
>> part = pg_pwritev(fd, iov, iovcnt, offset);
>> ^~~~~~~~~~
It would be better to provide this patch as an attachment so the cfbot
(http://commitfest.cputube.org/) can test it.
Regards,
--
-David
david@pgmasters.net
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: david@pgmasters.net, james.hilliard1@gmail.com, pgsql-hackers@lists.postgresql.org, s.shinderuk@postgrespro.ru, thomas.munro@gmail.com, tgl@sss.pgh.pa.us
Subject: Re: [PATCH v3 1/1] Fix detection of preadv/pwritev support for OSX.
In-Reply-To: <ef0dbb86-511d-94a0-de54-ce526c505a4a@pgmasters.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox