From: Sergei Kornilov <sk@zsrv.org>
To: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: michael.paquier@gmail.com <michael.paquier@gmail.com>
Cc: andres@anarazel.de <andres@anarazel.de>
Cc: peter.eisentraut@2ndquadrant.com <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] Restricting maximum keep segments by repslots
Date: Thu, 11 Jan 2018 12:55:27 +0300
Message-ID: <2798121515664527@web40g.yandex.ru> (raw)
In-Reply-To: <20180111.155910.26212237.horiguchi.kyotaro@lab.ntt.co.jp>
References: <CAB7nPqS4bhSsDm_47GVjQno=iU6thx13MQVwwXXKBHQwfwwNCA@mail.gmail.com>
<20171222.150320.244267360.horiguchi.kyotaro@lab.ntt.co.jp>
<337571513944260@web55j.yandex.ru>
<20180111.155910.26212237.horiguchi.kyotaro@lab.ntt.co.jp>
Hello
>> patch -p1 gives some "Stripping trailing CRs from patch"
>> messages for me, but applied to current HEAD and builds. After
>
> Hmm. I wonder why I get that complaint so often. (It's rather
> common? or caused by the MIME format of my mail?) I'd say with
> confidence that it is because you retrieved the patch file on
> Windows mailer.
I use Debian and web based mailer. Hm, i wget patches from links here https://www.postgresql.org/message-id/flat/20180111.155910.26212237.horiguchi.kyotaro%40lab.ntt.co.j... - applies clean both last and previous messages. Its strange.
Updated patches builds ok, but i found one failed test in make check-world: contrib/test_decoding/sql/ddl.sql at the end makes SELECT * FROM pg_replication_slots; which result of course was changed
And i still have no better ideas for naming. I think on something like
if (min_keep_lsn <= restart_lsn)
if (active_pid != 0)
status = "streaming";
else
status = "keeping";
else
status = "may_lost";
This duplicates an existing active field, but I think it's useful as slot status description.
wal_status streaming/keeping/lost/unknown as described in docs patch is also acceptable for me. Maybe anyone else has better idea?
Regards, Sergei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sk@zsrv.org, horiguchi.kyotaro@lab.ntt.co.jp, michael.paquier@gmail.com, andres@anarazel.de, peter.eisentraut@2ndquadrant.com
Subject: Re: [HACKERS] Restricting maximum keep segments by repslots
In-Reply-To: <2798121515664527@web40g.yandex.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox