public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Evan Jones <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific
Date: Sun, 18 Jun 2023 21:10:59 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <ZI+TK2kch0ZZ/[email protected]>
References: <CA+HWA9awUW0+RV_gO9r1ABZwGoZxPztcJxPy8vMFSTbTfi4jig@mail.gmail.com>
	<[email protected]>
	<CA+HWA9bET27MxdO4VOgK==w4P_G9H0aStCq+C_DP4YnarAw87g@mail.gmail.com>
	<[email protected]>
	<CA+HWA9bTRDf52DHyU+JOoqEALgRGRo5uHUYTFuduoj3cBfer+Q@mail.gmail.com>
	<ZI5i2NCWirDuE/[email protected]>
	<[email protected]>
	<[email protected]>
	<ZI+TK2kch0ZZ/[email protected]>

Michael Paquier <[email protected]> writes:
> Another thing that I was wondering, though..  Do you think that there
> would be an argument in being stricter in the hstore code regarding
> the handling of multi-byte characters with some checks based on
> IS_HIGHBIT_SET() when parsing the keys and values?

What have you got in mind?  We should already have validated encoding
correctness before the text ever gets to hstore_in, and I'm not clear
what additional checks would be useful.

			regards, tom lane

view thread (13+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox