public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Evan Jones <[email protected]>
Cc: Thomas Munro <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific
Date: Wed, 11 Oct 2023 08:34:33 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+HWA9aN-M1O-9Ma=_Pqz-uwzDA07DEk+pui7Zy7K7-Y1PjpUg@mail.gmail.com>
References: <[email protected]>
<ZI+TK2kch0ZZ/[email protected]>
<[email protected]>
<[email protected]>
<CA+HWA9ZRRxdL5FFTM4eTDyhmnzC-0tAo1kmu8Mndtjvs4O=G0Q@mail.gmail.com>
<ZJI+G7B/qblD6/[email protected]>
<[email protected]>
<[email protected]>
<CA+hUKGKdZz+z39vLsYazV5U80JaQreGC71+x5ZRdDD5JBG53zw@mail.gmail.com>
<CA+HWA9aN-M1O-9Ma=_Pqz-uwzDA07DEk+pui7Zy7K7-Y1PjpUg@mail.gmail.com>
On Tue, Oct 10, 2023 at 10:51:10AM -0400, Evan Jones wrote:
> Here is a quick demonstration of this issue, showing that the quoting
> behavior is different between these two. Mac OS X with the "default" locale
> includes quotes because ą includes 0x85 in its UTF-8 encoding:
Ugh. rowtypes.c has reminded me as well of gistfuncs.c in pageinspect
where included columns are printed in a ROW-like fashion. And it also
uses isspace() when we check if double quotes are needed or not. So
the use of the quotes would equally depend on what macos thinks is
a correct space in this case.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (13+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox