From: Tom Lane <tgl@sss.pgh.pa.us>
To: Raúl Marín Rodríguez <rmrodriguez@carto.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] pgbench tap tests fail if the path contains a perl special character
Date: Fri, 18 Jan 2019 12:35:49 -0500
Message-ID: <28495.1547832949@sss.pgh.pa.us> (raw)
In-Reply-To: <CAM6_UM6dGdU39PKAC24T+HD9ouy0jLN9vH6163K8QEEzr__iZw@mail.gmail.com>
References: <CAM6_UM6dGdU39PKAC24T+HD9ouy0jLN9vH6163K8QEEzr__iZw@mail.gmail.com>
=?UTF-8?B?UmHDumwgTWFyw61uIFJvZHLDrWd1ZXo=?= <rmrodriguez@carto.com> writes:
> As mentioned in the subject, if the $PATH where you are building postgres
> contains a perl's special character [1], for example a `+`, pgbench's tap
> tests will fail.
Fun. But is that really the only place that fails?
> I'm attaching a patch to fix this by using quotemeta [3].
This does not look right to me: glob has a different set of special
characters than regexes, no?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, rmrodriguez@carto.com
Subject: Re: [PATCH] pgbench tap tests fail if the path contains a perl special character
In-Reply-To: <28495.1547832949@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox