From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: samay sharma <smilingsamay@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Nathan Bossart <nathandbossart@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [RFC] building postgres with meson - v13
Date: Wed, 5 Oct 2022 08:40:59 +0200
Message-ID: <28de92b5-a514-fe1b-1637-ba228aa2cccf@enterprisedb.com> (raw)
In-Reply-To: <CAJxrbyxSjV0G7hCGKc=Ym2q=cy3g3Gd1tukfOXZncQqetw_cRA@mail.gmail.com>
References: <d861493c-ed20-c251-7a89-7924f5197341@enterprisedb.com>
<20220920021630.vufrgcjmidimcarq@awork3.anarazel.de>
<20220921164630.wrklkjmifjqjtlwc@awork3.anarazel.de>
<20220922055704.fngsvviugsnivebs@awork3.anarazel.de>
<2b9a02ec-22e6-24df-18ec-b60e3af12995@dunslane.net>
<20220922150550.pscsjv4nwnslupeg@awork3.anarazel.de>
<20220922200533.GA697326@nathanxps13>
<20220922202809.4touie37lfafyabw@awork3.anarazel.de>
<20220922223729.GA721620@nathanxps13>
<2298281.1664041949@sss.pgh.pa.us>
<20220924180955.2hevwoniwsj2q2tm@awork3.anarazel.de>
<c5736f70-bb6d-8d25-e35c-e3d886e4e905@enterprisedb.com>
<CAJxrbyxSjV0G7hCGKc=Ym2q=cy3g3Gd1tukfOXZncQqetw_cRA@mail.gmail.com>
On 03.10.22 09:39, samay sharma wrote:
> 9f5be26c1215 meson: Add docs for building with meson
>
> I do like the overall layout of this.
>
> The "Supported Platforms" section should be moved back to near the end
> of the chapter. I don't see a reason to move it forward, at least
> none that is related to the meson issue.
>
>
> Agreed that it's unrelated to meson. However, I think it's better to
> move it in the front as it's generally useful to know if your platform
> is supported before you start performing the installation steps and get
> stuck somewhere.
The way it is currently organized is that 17.2 says
"In general, a modern Unix-compatible platform should be able to run
PostgreSQL. The platforms that had received specific testing at the time
of release are described in Section 17.6 below."
So basically, it says, don't worry about it, your platform is probably
supported, but check below if you are interested in the details.
I don't see a reason to turn this around.
>
> Do you think I should submit that as a separate commit in the same
> patch-set or just move it out to a completely different patch submission?
>
>
> The changes to the "Getting the Source" section are also not
> appropriate for this patch.
>
>
> Given that many developers are now using Git for downloading the source
> code, I think it makes sense to be in the Getting the source section.
> Also, meson today doesn't cleanly build via the tarballs. Hence, I added
> it to the section (and patchset).
Section 17.3 already contains a link to section I.1 about using Git.
> Do you think I should move this to a different patch?
If you wanted to pursue these changes, then yes, but I think they are
not clear improvements, as mentioned above.
I suggest focusing on getting the actual meson documentation finished
and then considering polishing the overall flow if desired.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@enterprisedb.com, smilingsamay@gmail.com, andres@anarazel.de, tgl@sss.pgh.pa.us, nathandbossart@gmail.com, andrew@dunslane.net, thomas.munro@gmail.com, pryzby@telsasoft.com, byavuz81@gmail.com
Subject: Re: [RFC] building postgres with meson - v13
In-Reply-To: <28de92b5-a514-fe1b-1637-ba228aa2cccf@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox