From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Andres Freund <andres@anarazel.de>
To: pgsql-hackers@postgresql.org, Thomas Munro <thomas.munro@gmail.com>
To: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael.paquier@gmail.com>
Subject: Re: meson: Add support for building with precompiled headers
Date: Thu, 6 Oct 2022 09:06:42 +0200
Message-ID: <28e95b5f-9162-de57-c4da-a85b909bb9b0@enterprisedb.com> (raw)
In-Reply-To: <20221005190829.lda7ttalh4mzrvf4@awork3.anarazel.de>
References: <20221005190829.lda7ttalh4mzrvf4@awork3.anarazel.de>
On 05.10.22 21:08, Andres Freund wrote:
> This is a patch split off from the initial meson thread [1] as it's
> functionally largely independent (as suggested in [2]).
>
> Using precompiled headers substantially speeds up building for windows, due to
> the vast amount of headers included via windows.h. A cross build from
> linux targetting mingw goes from
These patches look ok to me. I can't really comment on the Windows
details, but it sounds all reasonable.
Small issue:
+override CFLAGS += -DFD_SETSIZE=1024
(and similar)
should be CPPFLAGS.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@enterprisedb.com, andres@anarazel.de, thomas.munro@gmail.com, pryzby@telsasoft.com, michael.paquier@gmail.com
Subject: Re: meson: Add support for building with precompiled headers
In-Reply-To: <28e95b5f-9162-de57-c4da-a85b909bb9b0@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox