pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Corey Huinker <corey.huinker@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: ts_locale.c: why no t_isalnum() test?
Date: Wed, 19 Oct 2022 18:39:32 -0400
Message-ID: <2933409.1666219172@sss.pgh.pa.us> (raw)
In-Reply-To: <CADkLM=fgm4_A7b9_pXE=QPCB+JpxD4sTRue4SXKk9TvkB0LWig@mail.gmail.com>
References: <2548310.1664999615@sss.pgh.pa.us>
	<CADkLM=fgm4_A7b9_pXE=QPCB+JpxD4sTRue4SXKk9TvkB0LWig@mail.gmail.com>

Corey Huinker <corey.huinker@gmail.com> writes:
> I see this is already committed, but I'm curious, why do t_isalpha and
> t_isdigit have the pair of /* TODO */ comments? This unfinished business
> isn't explained anywhere in the file.

We really ought to be consulting the locale/collation passed to
the SQL-level operator or function that's calling these things,
instead of hard-wiring the database default.  Passing that down
would take a large and boring patch, but somebody ought to tackle
it someday.

			regards, tom lane





view thread (3+ messages)

Message-ID: <2933409.1666219172@sss.pgh.pa.us>
Permalink:  ../2933409.1666219172@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2933409.1666219172@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, corey.huinker@gmail.com
  Subject: Re: ts_locale.c: why no t_isalnum() test?
  In-Reply-To: <2933409.1666219172@sss.pgh.pa.us>
  References: <2548310.1664999615@sss.pgh.pa.us> <CADkLM=fgm4_A7b9_pXE=QPCB+JpxD4sTRue4SXKk9TvkB0LWig@mail.gmail.com> <2933409.1666219172@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox