pg.ddx.io pgsql-hackers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: ilmari@ilmari.org
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Nikita Glukhov <n.gluhov@postgrespro.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Transform for pl/perl
Date: Mon, 18 Jun 2018 14:40:29 -0400
Message-ID: <2941.1529347229@sss.pgh.pa.us> (raw)
In-Reply-To: <d8jlgbq66t9.fsf@dalvik.ping.uio.no>
References: <20180606161453.tvp4ltavlcvejmmz@alvherre.pgsql>
<e5130c85-23da-5d11-ca74-6a050cc5fa85@2ndquadrant.com>
<d8jlgbq66t9.fsf@dalvik.ping.uio.no>
ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes:
> [ 0001-Fix-excess-enreferencing-in-plperl-jsonb-transform.patch ]
I tested this a bit more thoroughly by dint of applying Data::Dumper
to the Perl values, and found that we were still getting extra references
to sub-objects, for example
INFO: $VAR1 = {'1' => \{'2' => \['3','4','5']},'2' => '3'};
where what we want is
INFO: $VAR1 = {'1' => {'2' => ['3','4','5']},'2' => '3'};
That turns out to be because the newRV() call in JsonbValue_to_SV()
is also superfluous, if we've set up refs around HV and AV scalars.
Pushed with that change and the extra testing technology. I'll go
push the dereferencing patch I proposed shortly, as well.
The remaining unresolved issue in this thread is Ilmari's suggestion
that we should convert integers to Perl IV (or UV?) if they fit, rather
than always convert to NV as now. I'm inclined to reject that proposal,
though, and not just because we don't have a patch for it. What's
bothering me about it is that then the behavior would be dependent
on the width of IV in the particular Perl installation. I think that
is a platform dependency we can do without.
regards, tom lane
view thread (62+ messages) latest in thread
Message-ID: <2941.1529347229@sss.pgh.pa.us> Permalink: ../2941.1529347229@sss.pgh.pa.us/ Also on: postgresql.org/message-id/2941.1529347229@sss.pgh.pa.us ·
reply
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Reply to all the recipients using the --to and --cc options: reply via email To: pgsql-hackers@postgresql.org Cc: tgl@sss.pgh.pa.us, ilmari@ilmari.org, peter.eisentraut@2ndquadrant.com, alvherre@2ndquadrant.com, pavel.stehule@gmail.com, n.gluhov@postgrespro.ru, pgsql-hackers@lists.postgresql.org Subject: Re: Transform for pl/perl In-Reply-To: <2941.1529347229@sss.pgh.pa.us> * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox