pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Sergei Kornilov <sk@zsrv.org>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Álvaro Herrera <alvherre@2ndquadrant.com>
Subject: Re: Improve handling of parameter differences in physical replication
Date: Thu, 19 Nov 2020 22:17:34 +0300
Message-ID: <2985371605808012@mail.yandex.ru> (raw)
In-Reply-To: <5e93f9f5-9572-38d0-b740-f8a20dfcc165@2ndquadrant.com>
References: <CA+fd4k4G8pFDha522kPAh_H2d3be6ejc56H932h_xHXPA+mV5Q@mail.gmail.com>
	<20200310.175755.1250389993502025042.horikyota.ntt@gmail.com>
	<aa078efe-2d25-fdab-5bdb-158edab5d849@2ndquadrant.com>
	<20200311.110637.1319131984113864409.horikyota.ntt@gmail.com>
	<2134a29f-e934-4585-e81f-ab416e1923be@2ndquadrant.com>
	<CA+fd4k4G3pAY+KPDzNRCGu=FZQT81KhXT-8EcjYGpc6cpmiT9w@mail.gmail.com>
	<2808491585335240@iva3-67f911cb3a01.qloud-c.yandex.net>
	<f71030f1-cd0a-5e7c-5d09-cbebc6603bf5@2ndquadrant.com>
	<ddd72267-d4cb-4b4e-07af-4685316a2c92@2ndquadrant.com>
	<5e93f9f5-9572-38d0-b740-f8a20dfcc165@2ndquadrant.com>

Hello

Thank you! I'm on vacation, so I was finally able to review the patch.

Seems WAIT_EVENT_RECOVERY_PAUSE addition was lost during patch simplification.

> 		ereport(FATAL,
>				(errmsg("recovery aborted because of insufficient parameter settings"),
>				 errhint("You can restart the server after making the necessary configuration changes.")));

I think we should repeat here conflicted param_name and minValue. pg_wal_replay_resume can be called days after recovery being paused. The initial message can be difficult to find.

> errmsg("recovery will be paused")

May be use the same "recovery has paused" as in recoveryPausesHere? It doesn't seem to make any difference since we set pause right after that, but there will be a little less work translators.

Not sure about "If recovery is unpaused". The word "resumed" seems to have been usually used in docs.

regards, Sergei





view thread (27+ messages)  latest in thread

Message-ID: <2985371605808012@mail.yandex.ru>
Permalink:  ../2985371605808012@mail.yandex.ru/
Also on:    postgresql.org/message-id/2985371605808012@mail.yandex.ru

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: sk@zsrv.org, peter.eisentraut@2ndquadrant.com, masahiko.sawada@2ndquadrant.com, horikyota.ntt@gmail.com, alvherre@2ndquadrant.com
  Subject: Re: Improve handling of parameter differences in physical replication
  In-Reply-To: <2985371605808012@mail.yandex.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox