pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Sergei Kornilov <sk@zsrv.org>
To: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Álvaro Herrera <alvherre@2ndquadrant.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Improve handling of parameter differences in physical replication
Date: Mon, 30 Mar 2020 10:09:48 +0200
Message-ID: <f71030f1-cd0a-5e7c-5d09-cbebc6603bf5@2ndquadrant.com> (raw)
In-Reply-To: <2808491585335240@iva3-67f911cb3a01.qloud-c.yandex.net>
References: <CA+fd4k4G8pFDha522kPAh_H2d3be6ejc56H932h_xHXPA+mV5Q@mail.gmail.com>
	<20200310.175755.1250389993502025042.horikyota.ntt@gmail.com>
	<aa078efe-2d25-fdab-5bdb-158edab5d849@2ndquadrant.com>
	<20200311.110637.1319131984113864409.horikyota.ntt@gmail.com>
	<2134a29f-e934-4585-e81f-ab416e1923be@2ndquadrant.com>
	<CA+fd4k4G3pAY+KPDzNRCGu=FZQT81KhXT-8EcjYGpc6cpmiT9w@mail.gmail.com>
	<2808491585335240@iva3-67f911cb3a01.qloud-c.yandex.net>

On 2020-03-27 20:15, Sergei Kornilov wrote:
>> I think we can set wait event WAIT_EVENT_RECOVERY_PAUSE here.
> 
> +1, since we added this in recoveryPausesHere.

committed with that addition

> PS: do we need to add a prototype for the RecoveryRequiredIntParameter function in top of xlog.c?

There is no consistent style, I think, but I usually only add prototypes 
for static functions if they are required because of the ordering in the 
file.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services





view thread (27+ messages)  latest in thread

Message-ID: <f71030f1-cd0a-5e7c-5d09-cbebc6603bf5@2ndquadrant.com>
Permalink:  ../f71030f1-cd0a-5e7c-5d09-cbebc6603bf5@2ndquadrant.com/
Also on:    postgresql.org/message-id/f71030f1-cd0a-5e7c-5d09-cbebc6603bf5@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, sk@zsrv.org, masahiko.sawada@2ndquadrant.com, horikyota.ntt@gmail.com, alvherre@2ndquadrant.com
  Subject: Re: Improve handling of parameter differences in physical replication
  In-Reply-To: <f71030f1-cd0a-5e7c-5d09-cbebc6603bf5@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox