From: Tom Lane <tgl@sss.pgh.pa.us>
To: Victor Drobny <v.drobny@postgrespro.ru>
Cc: pgsql-hackers@postgresql.org
Subject: Re: A mistake in a comment
Date: Mon, 26 Jun 2017 09:54:04 -0400
Message-ID: <29896.1498485244@sss.pgh.pa.us> (raw)
In-Reply-To: <2b5382fdff9b1f79d5eb2c99c4d2cbe2@postgrespro.ru>
References: <2b5382fdff9b1f79d5eb2c99c4d2cbe2@postgrespro.ru>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Victor Drobny <v.drobny@postgrespro.ru> writes:
> I believe that I have found a mistake in a comment to
> parse_phrase_operator function. The comment has the following line:
> a <X> b (distance is no greater than X)
> which is not. According to documentation and practical results, this
> line should me changed on something like:
> a <X> b (distance is equal to X)
Ah, this comment got missed when we changed the definition of <N>.
> Patch in the attachments fixes the issue.
Will apply, thanks. Looks to me like there's an outright bug here
as well: if errno happened to already be ERANGE when we reach the
strtol() call, the code will incorrectly report an error.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, v.drobny@postgrespro.ru
Subject: Re: A mistake in a comment
In-Reply-To: <29896.1498485244@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox