pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jonathan S. Katz <jkatz@postgresql.org>
To: Robert Haas <robertmhaas@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: Christoph Berg <myon@debian.org>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: Joe Conway <mail@joeconway.com>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: David Rowley <dgrowleyml@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: How about a psql backslash command to show GUCs?
Date: Tue, 7 Jun 2022 10:52:38 -0400
Message-ID: <29d873fa-ce53-0eeb-ddf5-0a0d38458d16@postgresql.org> (raw)
In-Reply-To: <CA+Tgmob12ZKj-S6mnFbBMS7DPuiSHV8H0bd7UP=pXT+BYj8a3Q@mail.gmail.com>
References: <4105551.1649514677@sss.pgh.pa.us>
	<YlGtICTMIJ886Ij3@jrouhaud>
	<afad841b-cc31-1784-84f7-b6c3c71d0c5d@postgresql.org>
	<4115803.1649521632@sss.pgh.pa.us>
	<043bcb40-052f-5c85-63ff-d6a2b5a0b7ca@postgresql.org>
	<495595.1649704355@sss.pgh.pa.us>
	<9439380b-a81f-c910-f527-db4d470b026b@postgresql.org>
	<531275.1649707882@sss.pgh.pa.us>
	<7bba5a32-65fe-04e1-7c36-efd963a625c9@postgresql.org>
	<807242.1649776780@sss.pgh.pa.us>
	<20220606135529.GV29853@telsasoft.com>
	<918042.1654531335@sss.pgh.pa.us>
	<CA+TgmoZQUHhhrw8ZHAaM0jKdpx+5OP7b3pLwNEFDbk5C0VVpuQ@mail.gmail.com>
	<952350.1654549308@sss.pgh.pa.us>
	<CA+Tgmob12ZKj-S6mnFbBMS7DPuiSHV8H0bd7UP=pXT+BYj8a3Q@mail.gmail.com>

On 6/7/22 10:26 AM, Robert Haas wrote:
> On Mon, Jun 6, 2022 at 5:02 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I think a reasonable case can be made for excluding "internal" GUCs
>> on the grounds that (a) they cannot be set, and therefore (b) whatever
>> value they have might as well be considered the default.
> 
> I agree.

I think some of these could be interesting if they deviate from the 
default (e.g. "in_hot_standby") as it will give the user context on the 
current state of the system.

However, something like that is still fairly easy to determine (e.g. 
`pg_catalog.pg_is_in_recovery()`). And looking through the settings 
marked "internal" showing the non-defaults may not provide much 
additional context to a user.

+1 for excluding them.

Jonathan


Attachments:

  OpenPGP_signature (application/pgp-signature, 839B) download

view thread (71+ messages)  latest in thread

Message-ID: <29d873fa-ce53-0eeb-ddf5-0a0d38458d16@postgresql.org>
Permalink:  ../29d873fa-ce53-0eeb-ddf5-0a0d38458d16@postgresql.org/
Also on:    postgresql.org/message-id/29d873fa-ce53-0eeb-ddf5-0a0d38458d16@postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: jkatz@postgresql.org, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, pryzby@telsasoft.com, rjuju123@gmail.com, myon@debian.org, pavel.stehule@gmail.com, david.g.johnston@gmail.com, mail@joeconway.com, mark.dilger@enterprisedb.com, andrew@dunslane.net, dgrowleyml@gmail.com, alvherre@alvh.no-ip.org
  Subject: Re: How about a psql backslash command to show GUCs?
  In-Reply-To: <29d873fa-ce53-0eeb-ddf5-0a0d38458d16@postgresql.org>
  References: <4105551.1649514677@sss.pgh.pa.us> <YlGtICTMIJ886Ij3@jrouhaud> <afad841b-cc31-1784-84f7-b6c3c71d0c5d@postgresql.org> <4115803.1649521632@sss.pgh.pa.us> <043bcb40-052f-5c85-63ff-d6a2b5a0b7ca@postgresql.org> <495595.1649704355@sss.pgh.pa.us> <9439380b-a81f-c910-f527-db4d470b026b@postgresql.org> <531275.1649707882@sss.pgh.pa.us> <7bba5a32-65fe-04e1-7c36-efd963a625c9@postgresql.org> <807242.1649776780@sss.pgh.pa.us> <20220606135529.GV29853@telsasoft.com> <918042.1654531335@sss.pgh.pa.us> <CA+TgmoZQUHhhrw8ZHAaM0jKdpx+5OP7b3pLwNEFDbk5C0VVpuQ@mail.gmail.com> <952350.1654549308@sss.pgh.pa.us> <CA+Tgmob12ZKj-S6mnFbBMS7DPuiSHV8H0bd7UP=pXT+BYj8a3Q@mail.gmail.com> <29d873fa-ce53-0eeb-ddf5-0a0d38458d16@postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox