From: Arne Roland <A.Roland@index.de>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: vignesh C <vignesh21@gmail.com>
Cc: Zhihong Yu <zyu@yugabyte.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Rename of triggers for partitioned tables
Date: Thu, 22 Jul 2021 17:22:57 +0000
Message-ID: <29dca60bc79e4c2ab26fa328a94b1289@index.de> (raw)
In-Reply-To: <202107221620.vrxflq2i5y7l@alvherre.pgsql>
References: <724b9f97a96c470aab3bfee502366b7c@index.de>
<202107221620.vrxflq2i5y7l@alvherre.pgsql>
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
Sent: Thursday, July 22, 2021 18:20
To: Arne Roland
Subject: Re: Rename of triggers for partitioned tables
If we have good use for such an index, I don't see why we can't add it.
But I'm not sure that it is justified -- certainly if the only benefit
is to make ALTER TRIGGER RENAME recurse faster on partitioned tables, it
is not justified.
Speed is not really the issue here, most people will have under 20 triggers per table anyways. I think even the simpler code would be worth more than the speed gain. The main value of such an index would be the enforced uniqueness.
I just noticed that apparently the
ALTER TABLE [ IF EXISTS ] [ ONLY ] name [ ENABLE | DISABLE ] TRIGGER ...
syntax albeit looking totally different and it already recurses, it has precisely the same issue with pg_dump. In that case the ONLY syntax isn't optional and the 2. from your above post does inevitably apply.
Since it is sort of the same problem, I think it might be worthwhile to address it as well within this patch. Adding two to four ereports doesn't sound like scope creeping to me, even though it touches completely different code. I'll look into that as well.
Regards
Arne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: A.Roland@index.de, alvherre@alvh.no-ip.org, vignesh21@gmail.com, zyu@yugabyte.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Rename of triggers for partitioned tables
In-Reply-To: <29dca60bc79e4c2ab26fa328a94b1289@index.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox