From: Arne Roland <A.Roland@index.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: vignesh C <vignesh21@gmail.com>
Cc: Zhihong Yu <zyu@yugabyte.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Rename of triggers for partitioned tables
Date: Mon, 26 Jul 2021 18:11:28 +0000
Message-ID: <4217d1f783704ef7b9261e89065c24f2@index.de> (raw)
In-Reply-To: <171676.1627321096@sss.pgh.pa.us>
References: <202107261714.kuzrvstzrufh@alvherre.pgsql>
<171676.1627321096@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
Sent: Monday, July 26, 2021 19:38
To: Alvaro Herrera
Subject: Re: Rename of triggers for partitioned tables
> Yeah, we don't support partial indexes on catalogs, and this example
> doesn't make me feel like we ought to open that can of worms.
I asked why such an index doesn't exists already. I guess that answers it. I definitely don't want to push for supporting that, especially not knowing what it entails.
> But then maybe this function shouldn't assume there's only one match?
I'd consider a duplication here a serious bug. That is pretty much catalog corruption. Having two children within a single child table sounds like it would break a lot of things.
That being said this function is hardly performance critical. I don't know whether throwing an elog indicating what's going wrong here would be worth it.
Regards
Arne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: A.Roland@index.de, tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, vignesh21@gmail.com, zyu@yugabyte.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Rename of triggers for partitioned tables
In-Reply-To: <4217d1f783704ef7b9261e89065c24f2@index.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox