From: Andres Freund <andres@anarazel.de>
To: pgsql-hackers@lists.postgresql.org,Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: David Rowley <david.rowley@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Subject: Re: Using POPCNT and other advanced bit manipulation instructions
Date: Wed, 13 Feb 2019 20:44:49 +0100
Message-ID: <2F6CDF3B-08B9-4A15-ABDF-55D7F82AB76E@anarazel.de> (raw)
In-Reply-To: <7193.1550086814@sss.pgh.pa.us>
References: <20190213191829.GA19406@alvherre.pgsql>
<7193.1550086814@sss.pgh.pa.us>
Hi,
On February 13, 2019 8:40:14 PM GMT+01:00, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>> I've pushed this now. Let's see what the buildfarm has to say about
>it.
>
>It's likely to be hard to tell, given the amount of pink from the Ryu
>patch. If Andrew is not planning to clean that up PDQ, I'd suggest
>reverting that patch pending having some repairs for it.
I'd assume that breaking bit counting would cause distinct enough damage (compile time or crashes). That's not to say that reverting ryu shouldn't be considered (although I'm not that bothered by cross version, ia64 and cygwin failures, especially because the latter two might be hard to come by outside the bf).
Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: andres@anarazel.de, tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, andrew@tao11.riddles.org.uk, david.rowley@2ndquadrant.com, pgsql-hackers@lists.postgresql.org, thomas.munro@enterprisedb.com
Subject: Re: Using POPCNT and other advanced bit manipulation instructions
In-Reply-To: <2F6CDF3B-08B9-4A15-ABDF-55D7F82AB76E@anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox