public inbox for [email protected]  

help / color / mirror / Atom feed

From: Alexander Pyhalov <[email protected]>
To: Zhihong Yu <[email protected]>
Cc: Julien Rouhaud <[email protected]>
Cc: Daniel Gustafsson <[email protected]>
Cc: Ilya Gladyshev <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: Partial aggregates pushdown
Date: Mon, 17 Jan 2022 15:26:55 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <CALNJ-vSm6z6Lg1CgxbGUG6=xP3n+tYC_XGGUm33b9g98Z3bF-g@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<20220114121653.mjzqelwgnzwqhkoa@jrouhaud>
	<[email protected]>
	<CALNJ-vSm6z6Lg1CgxbGUG6=xP3n+tYC_XGGUm33b9g98Z3bF-g@mail.gmail.com>

Zhihong Yu писал 2022-01-17 11:43:
> Hi,
> +   FdwScanPrivateConvertors
> 
> + * Generate attinmeta if there are some converters:
> 
> I think it would be better if converter is spelled the same way across
> the patch.
> 
> For build_conv_list():
> 
> +   if (IS_UPPER_REL(foreignrel))
> 
> You can return NIL for !IS_UPPER_REL(foreignrel) - this would save
> indentation for the body of the func.

Hi.
Updated patch.

-- 
Best regards,
Alexander Pyhalov,
Postgres Professional

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Partial aggregates pushdown
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox