pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jeff Davis <pgsql@j-davis.com>
To: John Naylor <johncnaylorls@gmail.com>
Cc: Ants Aasma <ants.aasma@cybertec.at>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Junwang Zhao <zhjwpku@gmail.com>
Cc: jian he <jian.universality@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Gurjeet Singh <gurjeet@singh.im>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Change GUC hashtable to use simplehash?
Date: Wed, 27 Mar 2024 22:37:41 -0700
Message-ID: <2b0df3af97fac73a40aba16a58837e2cee594b1f.camel@j-davis.com> (raw)
In-Reply-To: <CANWCAZYxrJJ4EDw=o5vu_gAs7dS_PK6ry0rqkVu9opGpAJjoQQ@mail.gmail.com>
References: <c95e1821b6a69ec0c40eb0252e037b68a62cdae3.camel@j-davis.com>
	<CANWCAZa6QU8-pXDj2mrOhVx7c3=jws6nnhXv1FnfgTD5MXEuiQ@mail.gmail.com>
	<CANWCAZYP_BW2cCJkFYppVgC=4y7PJDZ7zc7SNWXyEuYhc0YMmA@mail.gmail.com>
	<CACJufxG6zR-t3dKoXfb_gqnHLH_CL2Pt3MPOOH2Hwx4t3e-eog@mail.gmail.com>
	<CANWCAZbm2tXPzDC8zOsREu9jQD2PbuGo-yyey_bY95QEQWo86w@mail.gmail.com>
	<CACJufxGy3JdpR8yo1ZzXjeLqQyV6+tSuom3zNjs-_6fnuxgBiQ@mail.gmail.com>
	<CANWCAZazJK37=bpVYhde5O9USXJVLNEbjB48gHGU85GT2T+xRg@mail.gmail.com>
	<CACJufxHkz13=p5nju7BN2buZsGVN_vFumEMmN3gdtBKssLj4WQ@mail.gmail.com>
	<CANWCAZY5LGQp-bjTDGpB0o6v4KCDEMD=f7PkV=ikeYTpncRWbA@mail.gmail.com>
	<CACJufxGvNummjj57mZ5sNqZRYBdreXTgKAJ0MC+0wjpj3+sc2w@mail.gmail.com>
	<CANWCAZbeG8vipVrvhHGd_5MDu414d6pMoYgCfJu49FJ8M3VbUw@mail.gmail.com>
	<CAEG8a3KnwqopxjHSm0rVy4jBKhOw7_25VWp0Gq6FDSdiqKOb=g@mail.gmail.com>
	<CANWCAZYh7UKNB9_LwmsDd2Go2TqLrDUXN=RRpwXFeVV=JCGBKA@mail.gmail.com>
	<CANWCAZbSFXbkSw+nOUeN0FD-pEV1Lqvc22H3QnWVhGREYMY-YA@mail.gmail.com>
	<3786e988-0dc6-4feb-866c-ab5215bf2394@iki.fi>
	<CANWCAZbEOdBagWQh9Omb=MiwjGJ88MNd-6ZYhxbwQXWPh0J4hA@mail.gmail.com>
	<611843ead9b111c763420bd09bbcb4a330032f8b.camel@j-davis.com>
	<09924cd6c49935d5e9bba5cd40bec28c605d7c2e.camel@j-davis.com>
	<CANWCAZZY+kZpMQh4OCJ1jrQigh_oCDWrbzWWOPTmJKj+0enR3A@mail.gmail.com>
	<48e8f8bbe0be9c789f98776c7438244ab7a7cc63.camel@j-davis.com>
	<CANwKhkP7pCiW_5fAswLhs71-JKGEz1c1+PC0a_w1fwY4iGMqUA@mail.gmail.com>
	<CANWCAZbXooNxa1oX4+N-QVTknRiiUBs17ai8rcWYihs_g=ShEQ@mail.gmail.com>
	<CANWCAZbg_XeSeY0a_PqWmWqeRATvzTzUNYRLeT+bzs+YQdC92g@mail.gmail.com>
	<CANWCAZbwvp7oUEkbw-xP4L0_S_WNKq-J-ucP4RCNDPJnrakUPw@mail.gmail.com>
	<458350a908d9607f7fc2a15407f4405cc454c970.camel@j-davis.com>
	<CANWCAZYxrJJ4EDw=o5vu_gAs7dS_PK6ry0rqkVu9opGpAJjoQQ@mail.gmail.com>

On Wed, 2024-03-27 at 13:44 +0700, John Naylor wrote:
> Thanks for the pointers! In v20-0001, I've drafted checking thes
> spelling first, since pg_attribute_no_sanitize_alignment has a
> similar
> version check. Then it checks for no_sanitize_address using
> __has_attribute, which goes back to gcc 5. That's plenty for the
> buildfarm and CI, and I'm not sure it's worth expending additional
> effort to cover more cases. (A similar attribute exists for MSVC in
> case it comes up.)

0001 looks good to me, thank you.

> v21-0003 adds a new file hashfn_unstable.c for convenience functions
> and converts all the duplicate frontend uses of hash_string_pointer.

Why not make hash_string() inline, too? I'm fine with it either way,
I'm just curious why you went to the trouble to create a new .c file so
it didn't have to be inlined.

Regards,
	Jeff Davis






view thread (103+ messages)  latest in thread

Message-ID: <2b0df3af97fac73a40aba16a58837e2cee594b1f.camel@j-davis.com>
Permalink:  ../2b0df3af97fac73a40aba16a58837e2cee594b1f.camel@j-davis.com/
Also on:    postgresql.org/message-id/2b0df3af97fac73a40aba16a58837e2cee594b1f.camel@j-davis.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: pgsql@j-davis.com, johncnaylorls@gmail.com, ants.aasma@cybertec.at, hlinnaka@iki.fi, zhjwpku@gmail.com, jian.universality@gmail.com, andres@anarazel.de, tgl@sss.pgh.pa.us, gurjeet@singh.im
  Subject: Re: Change GUC hashtable to use simplehash?
  In-Reply-To: <2b0df3af97fac73a40aba16a58837e2cee594b1f.camel@j-davis.com>
  References: <c95e1821b6a69ec0c40eb0252e037b68a62cdae3.camel@j-davis.com> <CANWCAZbSFXbkSw+nOUeN0FD-pEV1Lqvc22H3QnWVhGREYMY-YA@mail.gmail.com> <3786e988-0dc6-4feb-866c-ab5215bf2394@iki.fi> <CANWCAZbEOdBagWQh9Omb=MiwjGJ88MNd-6ZYhxbwQXWPh0J4hA@mail.gmail.com> <611843ead9b111c763420bd09bbcb4a330032f8b.camel@j-davis.com> <09924cd6c49935d5e9bba5cd40bec28c605d7c2e.camel@j-davis.com> <CANWCAZZY+kZpMQh4OCJ1jrQigh_oCDWrbzWWOPTmJKj+0enR3A@mail.gmail.com> <48e8f8bbe0be9c789f98776c7438244ab7a7cc63.camel@j-davis.com> <CANwKhkP7pCiW_5fAswLhs71-JKGEz1c1+PC0a_w1fwY4iGMqUA@mail.gmail.com> <CANWCAZbXooNxa1oX4+N-QVTknRiiUBs17ai8rcWYihs_g=ShEQ@mail.gmail.com> <CANWCAZbg_XeSeY0a_PqWmWqeRATvzTzUNYRLeT+bzs+YQdC92g@mail.gmail.com> <CANWCAZbwvp7oUEkbw-xP4L0_S_WNKq-J-ucP4RCNDPJnrakUPw@mail.gmail.com> <458350a908d9607f7fc2a15407f4405cc454c970.camel@j-davis.com> <CANWCAZYxrJJ4EDw=o5vu_gAs7dS_PK6ry0rqkVu9opGpAJjoQQ@mail.gmail.com> <2b0df3af97fac73a40aba16a58837e2cee594b1f.camel@j-davis.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox