From: Denis Laxalde <denis.laxalde@dalibo.com>
To: Jelte Fennema-Nio <postgres@jeltef.nl>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: vignesh C <vignesh21@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Greg Stark <stark@mit.edu>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Gregory Stark (as CFM) <stark.cfm@gmail.com>
Cc: Jelte Fennema <Jelte.Fennema@microsoft.com>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: Andres Freund <andres@anarazel.de>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Subject: Re: [EXTERNAL] Re: Add non-blocking version of PQcancel
Date: Wed, 6 Mar 2024 15:03:20 +0100
Message-ID: <2e2933ad-86b4-4fea-8876-5fcc0307e97c@dalibo.com> (raw)
In-Reply-To: <CAGECzQR9iU4E5s=nH7NA=h-dmi+S_=Th_UGEfLiQNDMBw_yVdQ@mail.gmail.com>
References: <CAGECzQQK=XBzAbp=HPVYUwNTV+z1fvmByhUx7TW_JDv8Hs3BhA@mail.gmail.com>
<202402141741.bifigsqxbj2m@alvherre.pgsql>
<CAGECzQR9iU4E5s=nH7NA=h-dmi+S_=Th_UGEfLiQNDMBw_yVdQ@mail.gmail.com>
In patch 0004, I noticed a couple of typos in the documentation; please
find attached a fixup patch correcting these.
Still in the documentation, same patch, the last paragraph documenting
PQcancelPoll() ends as:
+ indicate the current stage of the connection procedure and might
be useful
+ to provide feedback to the user for example. These statuses are:
+ </para>
while not actually listing the "statuses". Should we list them? Adjust
the wording? Or refer to PQconnectPoll() documentation (since the
paragraph is copied from there it seems)?
Otherwise, the feature still works fine as far as I can tell.
Attachments:
[text/x-patch] 0001-fixup-libpq-Add-encrypted-and-non-blocking-versions-.patch (1.6K, ../2e2933ad-86b4-4fea-8876-5fcc0307e97c@dalibo.com/2-0001-fixup-libpq-Add-encrypted-and-non-blocking-versions-.patch)
download | inline diff:
From 3e04442e3f283829ed38e4a2b435fd182addf87a Mon Sep 17 00:00:00 2001
From: Denis Laxalde <denis.laxalde@dalibo.com>
Date: Wed, 6 Mar 2024 14:55:40 +0100
Subject: [PATCH] fixup! libpq: Add encrypted and non-blocking versions of
PQcancel
---
doc/src/sgml/libpq.sgml | 2 +-
src/interfaces/libpq/fe-cancel.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/libpq.sgml b/doc/src/sgml/libpq.sgmlindex 1613fcc7bb..1281cac284 100644--- a/doc/src/sgml/libpq.sgml+++ b/doc/src/sgml/libpq.sgml@@ -6122,7 +6122,7 @@ PostgresPollingStatusType PQcancelPoll(PGcancelConn *cancelConn);
<para>
The request is made over the given <structname>PGcancelConn</structname>,
which needs to be created with <xref linkend="libpq-PQcancelConn"/>.
- The return value of <xref linkend="libpq-PQcancelBlocking"/>+ The return value of <xref linkend="libpq-PQcancelStart"/>
is 1 if the cancellation request could be started and 0 if not.
If it was unsuccessful, the error message can be
retrieved using <xref linkend="libpq-PQcancelErrorMessage"/>.
diff --git a/src/interfaces/libpq/fe-cancel.c b/src/interfaces/libpq/fe-cancel.cindex e66b8819ee..9c9a23bb4d 100644--- a/src/interfaces/libpq/fe-cancel.c+++ b/src/interfaces/libpq/fe-cancel.c@@ -146,7 +146,7 @@ PQcancelBlocking(PGcancelConn *cancelConn)
/*
* PQcancelStart
*
- * Starts sending a cancellation request in a blocking fashion. Returns+ * Starts sending a cancellation request in a non-blocking fashion. Returns
* 1 if successful 0 if not.
*/
int
--
2.39.2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: denis.laxalde@dalibo.com, postgres@jeltef.nl, alvherre@alvh.no-ip.org, vignesh21@gmail.com, thomas.munro@gmail.com, stark@mit.edu, tgl@sss.pgh.pa.us, stark.cfm@gmail.com, Jelte.Fennema@microsoft.com, daniel@yesql.se, peter@eisentraut.org, andres@anarazel.de, pryzby@telsasoft.com, robertmhaas@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: [EXTERNAL] Re: Add non-blocking version of PQcancel
In-Reply-To: <2e2933ad-86b4-4fea-8876-5fcc0307e97c@dalibo.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox