pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Thibaud W. <thibaud.walkowiak@dalibo.com>
To: pgsql-hackers@lists.postgresql.org
Subject: Re: Proposal: adding a better description in psql command about large objects
Date: Fri, 3 Jun 2022 10:12:30 +0200
Message-ID: <2e872233-1642-439c-dd94-56fc25d398cb@dalibo.com> (raw)
In-Reply-To: <20220602214625.GA2494933@nathanxps13>
References: <43f0439c-df3e-a045-ac99-af33523cc2d4@dalibo.com>
	<20220602214625.GA2494933@nathanxps13>

On 6/2/22 23:46, Nathan Bossart wrote:
> On Thu, Jun 02, 2022 at 11:12:46AM +0200, Thibaud W. wrote:
>> Attached is a small patch to add a description to the meta commands
>> regarding
>> large objects.
> This seems reasonable to me.  Your patch wasn't applying for some reason,
> so I created a new one with a commit message and some small adjustments.
> What do you think?
Thanks for reading and fixing.

In fact the original tabs were missing in the first file.
In version v2, it seems interesting to keep calls to the fprintf 
function for translation. I attached a new file.

Thanks.
Regards.
-- 
Thibaud W.

Attachments:

v3-0001-Add-descriptions-for-psql-s-large-object-backslas-1.patch (text/x-patch, 801B) download diff --git a/src/bin/psql/help.c b/src/bin/psql/help.c index 49eb116f33..b7dbd9f7f2 100644 --- a/src/bin/psql/help.c +++ b/src/bin/psql/help.c @@ -321,10 +321,10 @@ slashUsage(unsigned short int pager) fprintf(output, "\n"); fprintf(output, _("Large Objects\n")); - fprintf(output, _(" \\lo_export LOBOID FILE\n" - " \\lo_import FILE [COMMENT]\n" - " \\lo_list[+]\n" - " \\lo_unlink LOBOID large object operations\n")); + fprintf(output, _(" \\lo_export LOBOID FILE export large object to a file\n")); + fprintf(output, _(" \\lo_import FILE [COMMENT] import large object from a file\n")); + fprintf(output, _(" \\lo_list[+] list large objects\n")); + fprintf(output, _(" \\lo_unlink LOBOID delete a large object\n")); ClosePager(output); }

view thread (10+ messages)  latest in thread

Message-ID: <2e872233-1642-439c-dd94-56fc25d398cb@dalibo.com>
Permalink:  ../2e872233-1642-439c-dd94-56fc25d398cb@dalibo.com/
Also on:    postgresql.org/message-id/2e872233-1642-439c-dd94-56fc25d398cb@dalibo.com

 ·  · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: thibaud.walkowiak@dalibo.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Proposal: adding a better description in psql command about large objects
  In-Reply-To: <2e872233-1642-439c-dd94-56fc25d398cb@dalibo.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox