From: Thibaud W. <thibaud.walkowiak@dalibo.com>
To: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Proposal: adding a better description in psql command about large objects
Date: Tue, 7 Jun 2022 11:49:21 +0200
Message-ID: <e6311c32-c0cf-3dc0-b3d4-11dfa8ac73f3@dalibo.com> (raw)
In-Reply-To: <20220603172911.GA2671189@nathanxps13>
References: <43f0439c-df3e-a045-ac99-af33523cc2d4@dalibo.com>
<20220602214625.GA2494933@nathanxps13>
<2e872233-1642-439c-dd94-56fc25d398cb@dalibo.com>
<20220603143921.GA2624579@nathanxps13>
<216601.1654269131@sss.pgh.pa.us>
<20220603152319.GA2627191@nathanxps13>
<272177.1654275380@sss.pgh.pa.us>
<20220603172911.GA2671189@nathanxps13>
On 6/3/22 19:29, Nathan Bossart wrote:
> On Fri, Jun 03, 2022 at 12:56:20PM -0400, Tom Lane wrote:
>> Nathan Bossart <nathandbossart@gmail.com> writes:
>>> Another option could be to move it after the "Input/Output" section so that
>>> it's closer to some other commands that involve files. I can't say I have
>>> a strong opinion about whether/where to move it, though.
>> Yeah, I thought of that choice too, but it ends up placing the
>> Large Objects section higher up the list than seems warranted on
>> frequency-of-use grounds.
> Fair point.
>
>> After looking at the output I concluded that we'd be better off to
>> stick with the normal indentation amount, and break the lo_import
>> entry into two lines to make that work. One reason for this is
>> that some translators might've already settled on a different
>> indentation amount in order to cope with translated parameter names,
>> and deviating from the normal here will just complicate their lives.
>> So that leaves me proposing v5.
> I see. As you noted earlier, moving the entries higher makes the
> inconsistent indentation less appealing, too. So this LGTM.
>
>> (I also fixed the out-of-date line count in helpVariables.)
> Yeah, it looks like 7844c99 missed this.
Thanks, output is more readable this way.
Best regards.
--
Thibaud W.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: thibaud.walkowiak@dalibo.com, nathandbossart@gmail.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: Proposal: adding a better description in psql command about large objects
In-Reply-To: <e6311c32-c0cf-3dc0-b3d4-11dfa8ac73f3@dalibo.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox