pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
To: Melanie Plageman <melanieplageman@gmail.com>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Cc: Thomas Munro <thomas.munro@gmail.com>
Subject: Re: BitmapHeapScan streaming read user and prelim refactoring
Date: Thu, 14 Mar 2024 22:26:28 +0100
Message-ID: <2ed1e06b-feae-4c61-9f58-3fcc358104c7@enterprisedb.com> (raw)
In-Reply-To: <20240314181625.a7uigo5ujaogfd6x@liskov>
References: <20240216173559.xiy5xcl5dqmsprns@liskov>
	<20240227015028.knohvy3spaqwk7lf@liskov>
	<20240227142230.nu3ytvcjwouvczlt@liskov>
	<5f3b9d59-0f43-419d-80ca-6d04c07cf61a@iki.fi>
	<CAFiTN-vALdOjGA4zyKVrw93e8oTpeFxJWUKaeCrQczVw=W4DAQ@mail.gmail.com>
	<CA+Tgmob_5W8=kxPKbjzjy_UWO1QXv0Z53jnvLABJwuU7S4zL+Q@mail.gmail.com>
	<CAFiTN-sdUxh3O_7fh=iEVpmvZkALjywOkYu0LnqJcfDZEQdhVg@mail.gmail.com>
	<cd50927a-8b19-4f0f-884d-609212c71c91@iki.fi>
	<CAFiTN-vx1H0tCckC2ueiNTj+ibLHMGF4HYZyv99neHZkAzbWbQ@mail.gmail.com>
	<abf05d48-cecc-4f5b-8645-f9119d88f557@iki.fi>
	<20240314181625.a7uigo5ujaogfd6x@liskov>

On 3/14/24 19:16, Melanie Plageman wrote:
> On Thu, Mar 14, 2024 at 03:32:04PM +0200, Heikki Linnakangas wrote:
>> ...
>>
>> Ok, committed that for now. Thanks for looking!
> 
> Attached v6 is rebased over your new commit. It also has the "fix" in
> 0010 which moves BitmapAdjustPrefetchIterator() back above
> table_scan_bitmap_next_block(). I've also updated the Streaming Read API
> commit (0013) to Thomas' v7 version from [1]. This has the update that
> we theorize should address some of the regressions in the bitmapheapscan
> streaming read user in 0014.
> 

Should I rerun the benchmarks with these new patches, to see if it
really helps with the regressions?


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





view thread (248+ messages)  latest in thread

Message-ID: <2ed1e06b-feae-4c61-9f58-3fcc358104c7@enterprisedb.com>
Permalink:  ../2ed1e06b-feae-4c61-9f58-3fcc358104c7@enterprisedb.com/
Also on:    postgresql.org/message-id/2ed1e06b-feae-4c61-9f58-3fcc358104c7@enterprisedb.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tomas.vondra@enterprisedb.com, melanieplageman@gmail.com, hlinnaka@iki.fi, dilipbalaut@gmail.com, robertmhaas@gmail.com, byavuz81@gmail.com, andres@anarazel.de, thomas.munro@gmail.com
  Subject: Re: BitmapHeapScan streaming read user and prelim refactoring
  In-Reply-To: <2ed1e06b-feae-4c61-9f58-3fcc358104c7@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox