From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: pgsql-hackers@postgresql.org, Andres Freund <andres@anarazel.de>
Subject: Re: Should contrib modules install .h files?
Date: Fri, 14 Sep 2018 19:24:22 +0200
Message-ID: <2f32cff8-2358-23bf-4955-33fa789ecf79@2ndquadrant.com> (raw)
In-Reply-To: <384d19e8-bea1-1188-2324-f23f82a30d17@2ndquadrant.com>
References: <87y3euomjh.fsf@news-spur.riddles.org.uk>
<ee05ea4c-3d5b-0ec6-8daa-3ec66f021076@2ndquadrant.com>
<87tvpinfr4.fsf@news-spur.riddles.org.uk>
<63444.1530537990@sss.pgh.pa.us>
<12ba9c72-504f-b911-f0ce-1dff2826fa5b@2ndquadrant.com>
<87k1q8kokq.fsf@news-spur.riddles.org.uk>
<20180723014208.GE27724@tamriel.snowman.net>
<20180723032405.GF2854@paquier.xyz>
<21149.1532319353@sss.pgh.pa.us>
<dc5ad1a1-be01-ea26-1bb1-a6313cc0fffd@2ndquadrant.com>
<17977.1532362350@sss.pgh.pa.us>
<87o9exhq1x.fsf@news-spur.riddles.org.uk>
<384d19e8-bea1-1188-2324-f23f82a30d17@2ndquadrant.com>
On 01/08/2018 00:34, Peter Eisentraut wrote:
> On 23/07/2018 18:32, Andrew Gierth wrote:
>>>>>>> "Tom" == Tom Lane <tgl@sss.pgh.pa.us> writes:
>>
>> Tom> As I said before, I think that we should change the existing
>> Tom> contrib modules to be coded likewise, all using a single -I switch
>> Tom> that points at SRCDIR/contrib. That'd help give people the right
>> Tom> coding model to follow.
>>
>> I don't see that playing nicely with PGXS?
>
> I'm also not on board that my random third-party extension now has to
> refer to its own header files as "subdirectory/headerfile.h". Which
> will mess up existing extensions that have header files in their tree.
>
> Or at least I'm not totally sure what the exact proposal and real-world
> implications are, with regard to existing extensions with one or more
> header files.
>
> By all means, let's make it easier for large or small extensions to
> manage their header files with PGXS. But let's separate what PGXS can
> and should do from what the extension's own file layout is.
>
> But I think there are some fundamentally incompatible goals here with
> regard to how the final -I options are supposed to look.
Was this ever resolved?
Seems necessary to resolve for PG11.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, andrew@tao11.riddles.org.uk, tgl@sss.pgh.pa.us, michael@paquier.xyz, sfrost@snowman.net, andres@anarazel.de
Subject: Re: Should contrib modules install .h files?
In-Reply-To: <2f32cff8-2358-23bf-4955-33fa789ecf79@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox