From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Nitin Jadhav <nitinjadhavpostgres@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: when the startup process doesn't (logging startup delays)
Date: Wed, 29 Sep 2021 17:12:45 -0400
Message-ID: <3002163.1632949965@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmoZ3ZXqBQ1WSEn-Vo0+8V-8eAUO-fJcCmVUQ54Ecc6zNPQ@mail.gmail.com>
References: <202109291749.ejyaab7wazx7@alvherre.pgsql>
<2992585.1632938816@sss.pgh.pa.us>
<CA+TgmoZ3ZXqBQ1WSEn-Vo0+8V-8eAUO-fJcCmVUQ54Ecc6zNPQ@mail.gmail.com>
Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Sep 29, 2021 at 2:06 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> The real comment I'd have here, though, is that writing one-off
>> code for this purpose is bad. If we have a need for a repetitive
>> timeout, it'd be better to add the feature to timeout.c explicitly.
>> That would probably also remove the need for extra copies of the
>> timeout time.
> I'm not sure that really helps very much, honestly.
I didn't claim there are any other places that could use the feature
*today*. But once we've got one, it seems like there could be more
tomorrow. In any case, I dislike keeping timeout state data outside
timeout.c, because it's so likely to get out-of-sync that way.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, alvherre@alvh.no-ip.org, nitinjadhavpostgres@gmail.com, pryzby@telsasoft.com, michael@paquier.xyz, bharath.rupireddyforpostgres@gmail.com, andres@anarazel.de, sfrost@snowman.net, magnus@hagander.net, thomas.munro@gmail.com
Subject: Re: when the startup process doesn't (logging startup delays)
In-Reply-To: <3002163.1632949965@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox