pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Noah Misch <noah@leadboat.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Andrey M. Borodin <x4mmm@yandex-team.ru>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Amul Sul <sulamul@gmail.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: pg_amcheck contrib application
Date: Mon, 15 Mar 2021 13:04:14 -0400
Message-ID: <3012106.1615827854@sss.pgh.pa.us> (raw)
In-Reply-To: <20210313191841.GB3195145@rfd.leadboat.com>
References: <CAH2-WzmZJ3MWjaSEaysmkP8A7WL_TiCwOS8eT88yc-bwHgLOKg@mail.gmail.com>
	<CAH2-WznpwULZ3uJ1_6WXvNMXYbOy8k8tYs3r=qSdGmZeRd6tDw@mail.gmail.com>
	<CA+TgmoZUJ4j31CbnUz-DpBBq_DVoaYcuG5XB7hP71+uQ=js_KQ@mail.gmail.com>
	<CA+TgmoZ1DP0pkLyuG9y7Jtn2v7N-+dnVxbvBAT__u4-d=UYmbw@mail.gmail.com>
	<A80D68F6-E38F-482D-9522-E2FB6AAFE8A1@enterprisedb.com>
	<CA+TgmoY3_U=QuQWo4DArBSp+tg2MiCHLwDN_9U2H_iTxj3UcjA@mail.gmail.com>
	<9E76E46A-48B2-4869-BD0C-422204C1F767@enterprisedb.com>
	<F0A1FD70-A2F4-4528-8A03-8650CAEC0554@enterprisedb.com>
	<20210313184612.GA3195145@rfd.leadboat.com>
	<930621E5-5D10-456D-8CE4-CF629A6C4669@enterprisedb.com>
	<20210313191841.GB3195145@rfd.leadboat.com>

Looks like we're not quite out of the woods, as hornet and tern are
still unhappy:

#   Failed test 'pg_amcheck excluding all corrupt schemas status (got 2 vs expected 0)'
#   at t/003_check.pl line 498.

#   Failed test 'pg_amcheck excluding all corrupt schemas stdout /(?^:^$)/'
#   at t/003_check.pl line 498.
#                   'heap table "db1"."pg_catalog"."pg_statistic", block 2, offset 1, attribute 27:
#     final toast chunk number 0 differs from expected value 1
# heap table "db1"."pg_catalog"."pg_statistic", block 2, offset 1, attribute 27:
#     toasted value for attribute 27 missing from toast table
# '
#     doesn't match '(?^:^$)'
# Looks like you failed 2 tests of 60.
[12:18:06] t/003_check.pl ........... 
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/60 subtests 

These animals have somewhat weird alignment properties: MAXALIGN is 8
but ALIGNOF_DOUBLE is only 4.  I speculate that that is affecting their
choices about whether an out-of-line TOAST value is needed, breaking
this test case.

			regards, tom lane





view thread (161+ messages)  latest in thread

Message-ID: <3012106.1615827854@sss.pgh.pa.us>
Permalink:  ../3012106.1615827854@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3012106.1615827854@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, mark.dilger@enterprisedb.com, noah@leadboat.com, robertmhaas@gmail.com, pg@bowt.ie, thomas.munro@gmail.com, x4mmm@yandex-team.ru, sfrost@snowman.net, michael@paquier.xyz, sulamul@gmail.com, dilipbalaut@gmail.com, andres@anarazel.de
  Subject: Re: pg_amcheck contrib application
  In-Reply-To: <3012106.1615827854@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox