pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Use -fvisibility=hidden for shared libraries
Date: Wed, 27 Jul 2022 14:02:28 -0400
Message-ID: <3022536.1658944948@sss.pgh.pa.us> (raw)
In-Reply-To: <20220718220938.5yx7if2mru3rd6jc@awork3.anarazel.de>
References: <20211101020311.av6hphdl6xbjbuif@alap3.anarazel.de>
	<b8103d16bf26cff7a393d1de690474dbd9afaa19.camel@cybertec.at>
	<20211101054700.z3jzmc5lnxlad4y7@alap3.anarazel.de>
	<2499085.1641859296@sss.pgh.pa.us>
	<20220111025328.iq5g6uck53j5qtin@alap3.anarazel.de>
	<5b8d48a4-2fee-6764-7eda-a076f544ea33@enterprisedb.com>
	<20220716201750.qq6xwegkgp7xqi5w@awork3.anarazel.de>
	<180138.1658084088@sss.pgh.pa.us>
	<20220718070516.z4suhhdomktmrenb@awork3.anarazel.de>
	<20220718220938.5yx7if2mru3rd6jc@awork3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> On 2022-07-18 00:05:16 -0700, Andres Freund wrote:
>> Given that that's just about all compilers we support using configure, perhaps
>> we should just move that out of the compiler specific section? Doesn't look
>> like there's much precedent for that so far...

> Here's a potential patch along those lines.

Now that the dust from the main patch is pretty well settled, +1
for trying that.

> I wonder if we also should move the -fno-strict-aliasing, -fwrapv tests
> out. But that'd be something for later.

Those seem less likely to be portable to non-gcc-alike compilers.
On the other hand, maybe it'd be interesting to just remove the
conditionality temporarily and try ALL the switches on all compilers,
just to see what we can learn from the buildfarm.

			regards, tom lane





view thread (23+ messages)  latest in thread

Message-ID: <3022536.1658944948@sss.pgh.pa.us>
Permalink:  ../3022536.1658944948@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3022536.1658944948@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, peter.eisentraut@enterprisedb.com, laurenz.albe@cybertec.at
  Subject: Re: Use -fvisibility=hidden for shared libraries
  In-Reply-To: <3022536.1658944948@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox