From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Unstable regression test for contrib/pageinspect
Date: Sun, 20 Nov 2022 23:46:13 -0500
Message-ID: <3044433.1669005973@sss.pgh.pa.us> (raw)
In-Reply-To: <CAH2-Wz=3vJhW9CttOREb3ObDq0VdZFUgdgwu1_x=Ra_MFFskDQ@mail.gmail.com>
References: <2892135.1668976646@sss.pgh.pa.us>
<CAH2-Wz=3vJhW9CttOREb3ObDq0VdZFUgdgwu1_x=Ra_MFFskDQ@mail.gmail.com>
Peter Geoghegan <pg@bowt.ie> writes:
> On Sun, Nov 20, 2022 at 12:37 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> The core reloptions.sql and vacuum.sql tests are two places that are
>> also using this option, but they are applying it to temp tables,
>> which I think makes it safe (and the lack of failures, seeing that
>> they run within parallel test groups, reinforces that). Can we apply
>> that idea in pageinspect?
> I believe so. The temp table horizons guarantee isn't all that old, so
> the tests may well have been written before it was possible.
Ah, right, I see that that only dates back to v14 (cf a7212be8b).
So we can fix pageinspect's issue by making that table be temp,
but only as far back as v14.
That's probably good enough in terms of reducing the buildfarm
noise level, seeing that mamba has only reported this failure
on HEAD so far. I'd be tempted to propose back-patching
a7212be8b, but there would be ABI-stability issues, and it's
probably not worth dealing with that.
>> contrib/amcheck and contrib/pg_visibility are also using
>> DISABLE_PAGE_SKIPPING, so I wonder if they have similar hazards.
> I think that most use of DISABLE_PAGE_SKIPPING by the regression tests
> just isn't necessary.
Apparently not -- see followup discussion with Mark Dilger.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pg@bowt.ie, pgsql-hackers@lists.postgresql.org
Subject: Re: Unstable regression test for contrib/pageinspect
In-Reply-To: <3044433.1669005973@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox