From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ashutosh Sharma <ashu.coek88@gmail.com>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Dave Page <dpage@pgadmin.org>
Cc: Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: pl/perl extension fails on Windows
Date: Wed, 19 Jul 2017 12:12:43 -0400
Message-ID: <30585.1500480763@sss.pgh.pa.us> (raw)
In-Reply-To: <CAE9k0Pnvw63MLR=dT1NYdL_t_ptyFqW1ueJwixcsmobadpFWng@mail.gmail.com>
References: <CANFyU97OVQ3+Mzfmt3MhuUm5NwPU=-FtbNH5Eb7nZL9ua8=rcA@mail.gmail.com>
<4569.1499873707@sss.pgh.pa.us>
<CA+OCxox=h5xftcnyk1AfA_QKSQSruD=Er0qweZakiCEg3U4rcg@mail.gmail.com>
<6063dd4c-cd1e-d9d8-fa0d-3bddb1403c66@2ndQuadrant.com>
<CAE9k0PkWhEeNS4b5bnoQLeZsnqe4zqkr=4GhN2Ybt1nSsBFk2g@mail.gmail.com>
<184f1fb9-dfa2-ef2d-024b-7933486e018a@2ndQuadrant.com>
<16093.1499956602@sss.pgh.pa.us>
<bb3d3eb6-e310-471c-1d8c-d239ecaf52ad@2ndQuadrant.com>
<7480.1499965218@sss.pgh.pa.us>
<CAE9k0Pnvw63MLR=dT1NYdL_t_ptyFqW1ueJwixcsmobadpFWng@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Ashutosh Sharma <ashu.coek88@gmail.com> writes:
> Actually the function used for generation of handshake Key i.e HS_KEYp()
> considers 'sizeof(PerlInterpreter)' to generate the key and somehow the
> sizeof PerlInterpreter is not uniform in plperl and perl modules incase of
> Windows but on Linux it remains same in both the modules.
Yipes. So actually, this is catching a live ABI problem, which presumably
we've escaped seeing bad effects from only through sheer good luck.
I suppose that the discrepancies in the struct contents only occur after
the last field that plperl happens to touch directly --- but that is
unlikely to be true forever.
> *typedef struct interpreter PerlInterpreter;struct interpreter {# include
> "intrpvar.h"};*
> where intrpvar.h has different variables defined inside it and most of the
> variables definition are protected with various macros. And there are some
> macros that are just defined in perl but not in plperl module which means
> the sizeof(PerlInterpreter) on the two modules are going to be different
> and thereby resulting in a different key.
I imagine the route to a solution is to fix things so that the relevant
macros are all defined correctly in both cases. But why they aren't
already is certainly an interesting question. Have you identified just
which fields are added or missing relative to what libperl thinks?
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, ashu.coek88@gmail.com, andrew.dunstan@2ndquadrant.com, dpage@pgadmin.org, sandeep.thakkar@enterprisedb.com
Subject: Re: pl/perl extension fails on Windows
In-Reply-To: <30585.1500480763@sss.pgh.pa.us>
References: <CANFyU97OVQ3+Mzfmt3MhuUm5NwPU=-FtbNH5Eb7nZL9ua8=rcA@mail.gmail.com> <4569.1499873707@sss.pgh.pa.us> <CA+OCxox=h5xftcnyk1AfA_QKSQSruD=Er0qweZakiCEg3U4rcg@mail.gmail.com> <6063dd4c-cd1e-d9d8-fa0d-3bddb1403c66@2ndQuadrant.com> <CAE9k0PkWhEeNS4b5bnoQLeZsnqe4zqkr=4GhN2Ybt1nSsBFk2g@mail.gmail.com> <184f1fb9-dfa2-ef2d-024b-7933486e018a@2ndQuadrant.com> <16093.1499956602@sss.pgh.pa.us> <bb3d3eb6-e310-471c-1d8c-d239ecaf52ad@2ndQuadrant.com> <7480.1499965218@sss.pgh.pa.us> <CAE9k0Pnvw63MLR=dT1NYdL_t_ptyFqW1ueJwixcsmobadpFWng@mail.gmail.com> <30585.1500480763@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox