From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Noah Misch <noah@leadboat.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Extending USE_MODULE_DB to more test suite types
Date: Mon, 01 Apr 2019 13:36:58 -0400
Message-ID: <30785.1554140218@sss.pgh.pa.us> (raw)
In-Reply-To: <20190401170658.ugoa7babvrxw2paa@alap3.anarazel.de>
References: <20190401135213.GE891537@rfd.leadboat.com>
<20190401170658.ugoa7babvrxw2paa@alap3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> On 2019-04-01 06:52:13 -0700, Noah Misch wrote:
>> I plan to back-patch the PostgreSQL patch, to combat buildfarm noise. Perhaps
>> someone has test automation that sets USE_MODULE_DB and nonetheless probes the
>> exact database name "pl_regression", but I'm not too worried. The original
>> rationale for USE_MODULE_DB, in commit ad69bd0, was to facilitate pg_upgrade
>> testing. Folks using "make installcheck-world" to populate a cluster for
>> pg_upgrade testing will see additional test coverage, which may cause
>> additional failures. I'm fine with that, too.
> +1 for all of that.
I haven't tested the patch, but also +1 for the idea.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, noah@leadboat.com
Subject: Re: Extending USE_MODULE_DB to more test suite types
In-Reply-To: <30785.1554140218@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox