pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Petr Jelinek <petr.jelinek@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Replication vs. float timestamps is a disaster
Date: Mon, 20 Feb 2017 09:07:33 -0500
Message-ID: <31590.1487599653@sss.pgh.pa.us> (raw)
In-Reply-To: <20170220110456.2jupmfhxlizykmmc@alap3.anarazel.de>
References: <26788.1487455319@sss.pgh.pa.us>
	<CA+TgmoafyUzmg8T-rKEgmkX7F1iQLSrKBmqKa26EattXpMS-ng@mail.gmail.com>
	<1691.1487519369@sss.pgh.pa.us>
	<20170220070311.gscn7ppqbwlgdpjq@alap3.anarazel.de>
	<3bd3c551-8b23-45c8-27a2-97b5a922b130@2ndquadrant.com>
	<20170220110456.2jupmfhxlizykmmc@alap3.anarazel.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Andres Freund <andres@anarazel.de> writes:
> On 2017-02-20 11:58:12 +0100, Petr Jelinek wrote:
>> That being said, I did wonder myself if we should just deprecate float
>> timestamps as well.

> I think we need a proper deprecation period for that, given that the
> conversion away will be painful for pg_upgrade using people with big
> clusters.  So I think we should fix this regardless... :(

The question to be asked is whether there is still anybody out there
using float timestamps.  I'm starting to get dubious about it myself.
Certainly, no packager that I'm aware of has shipped a float-timestamp
build since we switched the default in 8.4.  Maybe there is somebody
who's faithfully built a float-timestamp custom build every year so they
can pg_upgrade in place from their 8.3 installation, but there have got
to be darn few such people.

As for "proper deprecation period", the documentation has called the
option deprecated since 8.4:

-disable-integer-datetimes
	Disable support for 64-bit integer storage for timestamps and
	intervals, and store datetime values as floating-point numbers
	instead. Floating-point datetime storage was the default in
	PostgreSQL releases prior to 8.4, but it is now deprecated,
	because it does not support microsecond precision for the full
	range of timestamp values.

I think the strongest reason why we didn't move to kill it sooner was
that we were not then assuming that every platform had 64-bit ints;
but we've required that since 9.0.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (33+ messages)  latest in thread

Message-ID: <31590.1487599653@sss.pgh.pa.us>
Permalink:  ../31590.1487599653@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/31590.1487599653@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, petr.jelinek@2ndquadrant.com, robertmhaas@gmail.com
  Subject: Re: Replication vs. float timestamps is a disaster
  In-Reply-To: <31590.1487599653@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox