pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Gurjeet Singh <gurjeet@singh.im>
Cc: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter_e@gmx.net>
Cc: PGSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: /proc/self/oom_adj is deprecated in newer Linux kernels
Date: Tue, 10 Jun 2014 12:05:56 -0400
Message-ID: <31652.1402416356@sss.pgh.pa.us> (raw)
In-Reply-To: <CABwTF4WmOg_YjJs9igdeUkRcBmPeGAtX_uCxoYPHueczuK+Zbw@mail.gmail.com>
References: <29121.1316185073@sss.pgh.pa.us>
	<1316355543.12186.9.camel@vanquo.pezone.net>
	<15953.1316362868@sss.pgh.pa.us>
	<1316420754.14001.3.camel@fsopti579.F-Secure.com>
	<16241.1316441883@sss.pgh.pa.us>
	<CABwTF4XDdYiBQXqj=CKrFXN7x2NiBbVnpHSJG6AVnMBLnLBmLA@mail.gmail.com>
	<20140610143202.GI8406@alap3.anarazel.de>
	<30402.1402412692@sss.pgh.pa.us>
	<20140610150933.GK8406@alap3.anarazel.de>
	<30709.1402413628@sss.pgh.pa.us>
	<20140610153347.GM8406@alap3.anarazel.de>
	<31348.1402415537@sss.pgh.pa.us>
	<CABwTF4WmOg_YjJs9igdeUkRcBmPeGAtX_uCxoYPHueczuK+Zbw@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Gurjeet Singh <gurjeet@singh.im> writes:
> On Tue, Jun 10, 2014 at 11:52 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Robert's idea of having the start script set an environment variable to
>> control the OOM adjustment reset seems like it would satisfy my concern.

> I'm fine with this solution. Should this be a constant 0, or be
> configurable based on env. variable's value?

If we're going to do this, I would say that we should also take the
opportunity to get out from under the question of which kernel API
we're dealing with.  So perhaps a design like this:

1. If the environment variable PG_OOM_ADJUST_FILE is defined, it's
the name of a file to write something into after forking.  The typical
value would be "/proc/self/oom_score_adj" or "/proc/self/oom_adj".
If not set, nothing happens.

2. If the environment variable PG_OOM_ADJUST_VALUE is defined, that's
the string we write, otherwise we write "0".

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (66+ messages)  latest in thread

Message-ID: <31652.1402416356@sss.pgh.pa.us>
Permalink:  ../31652.1402416356@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/31652.1402416356@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, gurjeet@singh.im, andres@anarazel.de, peter_e@gmx.net
  Subject: Re: /proc/self/oom_adj is deprecated in newer Linux kernels
  In-Reply-To: <31652.1402416356@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox