pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Petr Jelinek <petr.jelinek@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Erik Rijkers <er@xs4all.nl>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Craig Ringer <craig@2ndquadrant.com>
Subject: Re: snapbuild woes
Date: Fri, 5 May 2017 13:53:16 +0200
Message-ID: <316d270d-d97e-65ba-dcdd-34f6b13698f6@2ndquadrant.com> (raw)
In-Reply-To: <20170505004237.edtahvrwb3uwd5rs@alap3.anarazel.de>
References: <0d06dfc1-0bc5-c3ab-3555-24e2f275d7fa@2ndquadrant.com>
	<30242bc6-eca4-b7bb-670e-8d0458753a8c@2ndquadrant.com>
	<20170501005921.qcqd7w2njpv3av6s@alap3.anarazel.de>
	<20170501013529.sejtgo2acxbvq26q@alap3.anarazel.de>
	<209861fc-718f-0a7b-3a1d-36512865c209@2ndquadrant.com>
	<20170501080348.vb6mj5whdex3f7l7@alap3.anarazel.de>
	<e6c1fdfe-50bc-62e4-3ad7-854f6ac5c35e@2ndquadrant.com>
	<20170501191419.coqbtx2jodu22ufz@alap3.anarazel.de>
	<ba7a3052-6e71-d162-d4a0-b5bdd7145c19@2ndquadrant.com>
	<20170505000004.gihrtl7bhxeolf3q@alap3.anarazel.de>
	<20170505004237.edtahvrwb3uwd5rs@alap3.anarazel.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On 05/05/17 02:42, Andres Freund wrote:
> On 2017-05-04 17:00:04 -0700, Andres Freund wrote:
>> Attached is a prototype patch for that.
> 

I am not sure I understand the ABI comment for started_collection_at.
What's the ABI issue? The struct is private to snapbuild.c module. Or
you want to store it in the ondisk snapshot as well?

About better name for it what about something like oldest_full_xact?

Otherwise the logic seems to be right on first read, will ponder it a
bit more

-- 
  Petr Jelinek                  http://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (92+ messages)  latest in thread

Message-ID: <316d270d-d97e-65ba-dcdd-34f6b13698f6@2ndquadrant.com>
Permalink:  ../316d270d-d97e-65ba-dcdd-34f6b13698f6@2ndquadrant.com/
Also on:    postgresql.org/message-id/316d270d-d97e-65ba-dcdd-34f6b13698f6@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: petr.jelinek@2ndquadrant.com, andres@anarazel.de, er@xs4all.nl, robertmhaas@gmail.com, craig@2ndquadrant.com
  Subject: Re: snapbuild woes
  In-Reply-To: <316d270d-d97e-65ba-dcdd-34f6b13698f6@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox