From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org, Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm
Date: Tue, 13 Jul 2021 00:25:06 -0400
Message-ID: <3198753.1626150306@sss.pgh.pa.us> (raw)
In-Reply-To: <YOzy2rlluWYYoUvW@paquier.xyz>
References: <3185430.1626133592@sss.pgh.pa.us>
<YOzy2rlluWYYoUvW@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> On Mon, Jul 12, 2021 at 07:46:32PM -0400, Tom Lane wrote:
>> Autoconf's AC_CHECK_DECLS always defines HAVE_DECL_whatever
>> as 1 or 0, but some of the entries in msvc/Solution.pm show
>> such symbols as "undef" instead. Shouldn't we fix it as
>> per attached? This is probably only cosmetic at the moment,
>> but it could bite us someday if someone wrote a complex
>> conditional using one of these symbols.
> Hmm. I have not tested, but agreed that this is inconsistent. I
> would tend to vote for a backpatch to keep some consistency across the
> branches as changes in this area could easily lead to rather conflicts
> harder to parse.
That's easy enough in v13 and up, which have 8f4fb4c64 so that
Solution.pm looks like this. We could make it consistent in older
branches by manually hacking pg_config.h.win32 ... but I'm wondering
if the smarter plan wouldn't be to back-patch 8f4fb4c64. Without
that, we're at risk of messing up anytime we back-patch something
that involves a change in the set of configure-defined symbols, which
we do with some regularity.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, peter.eisentraut@enterprisedb.com
Subject: Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm
In-Reply-To: <3198753.1626150306@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox