From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm
Date: Tue, 13 Jul 2021 17:01:53 +0200
Message-ID: <ca06751a-deb1-6f07-b1ac-7c4df17e392d@enterprisedb.com> (raw)
In-Reply-To: <YO1GcUp9IPVU9wuJ@paquier.xyz>
References: <3185430.1626133592@sss.pgh.pa.us>
<YOzy2rlluWYYoUvW@paquier.xyz>
<3198753.1626150306@sss.pgh.pa.us>
<YO1GcUp9IPVU9wuJ@paquier.xyz>
On 13.07.21 09:53, Michael Paquier wrote:
> I was thinking to just do the easiest move and fix this issue down to
> 13, not bothering about older branches :p
>
> Looking at the commit, a backpatch is not that complicated and it is
> possible to check the generation of pg_config.h on non-MSVC
> environments if some objects are missing. Still, I think that it
> would be better to be careful and test this code properly on Windows
> with a real build. It means that.. Err... Andrew or I should look
> at that. I am not sure that the potential maintenance gain is worth
> poking at the stable branches, to be honest.
We have lived with the previous system for a decade, so I think
backpatching this would be a bit excessive.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@enterprisedb.com, michael@paquier.xyz, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm
In-Reply-To: <ca06751a-deb1-6f07-b1ac-7c4df17e392d@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox