public inbox for [email protected]  
help / color / mirror / Atom feed
From: Peter Eisentraut <[email protected]>
To: Paul A Jungwirth <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Aleksander Alekseev <[email protected]>
Cc: PostgreSQL Development <[email protected]>
Subject: Re: [PATCH] Fix null pointer dereference in PG19
Date: Fri, 10 Jul 2026 10:42:29 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+renyWb-253nMz4OXPwn5ebXF7oJqT2Wu=qrGv=awYFqOk2LA@mail.gmail.com>
References: <CAJ7c6TME+ix6VRf-2TPnVTsj8qn_hy6sYAOmMhZEivwsu2wS6g@mail.gmail.com>
	<CA+renyW52FJ=+pnh+N_xqjUev_MNUCk_mgD2UC7UT0jyAHCE8Q@mail.gmail.com>
	<[email protected]>
	<CAJ7c6TO+kTwk5MBayLARxsPk-YCsDt2QH9P_PeTYoc3zPYCS3Q@mail.gmail.com>
	<CA+renyU6UZnpkgAuog0BVhqyD=G+_UVLzN2Ccpt2sV-qkF-_VQ@mail.gmail.com>
	<CAJ7c6TN7dekEHU8Vu4jV5+Zq7h2cVZQgwkYFCrU0jrjT26-ANw@mail.gmail.com>
	<CA+renyXs5mkPb-Vg=uF2Hj0jP2ufutc1_Eht=eb3+b_WpjiqLg@mail.gmail.com>
	<[email protected]>
	<CA+renyUkKaWtWZX2UcojKVjM=f1F5kgdvR8Pr5QqyJqqe_dw-g@mail.gmail.com>
	<[email protected]>
	<CA+renyXPEJYOVov3XtzTp3NusGkObc9UeW-Nm78K8_nsWSnnfg@mail.gmail.com>
	<[email protected]>
	<CA+renyV1WUtDSOHpNVv3fhD6JqhzZY_mV-0Nks23MczXLxpE8A@mail.gmail.com>
	<[email protected]>
	<CA+renyWb-253nMz4OXPwn5ebXF7oJqT2Wu=qrGv=awYFqOk2LA@mail.gmail.com>

On 09.07.26 17:22, Paul A Jungwirth wrote:
> Checking at v1 is Aleksander's original patch. Then v2 adds tests that
> crash the server. v3 moves the check to rewrite time, and the tests
> pass. v4 moves the check again to exec time. But v4 is a behavior
> change: an UPDATE that touches zero rows no longer fails. I thought
> that was weird; that's why I recommended leaving it out (in
> https://www.postgresql.org/message-id/ 
> CA%2BrenyXPEJYOVov3XtzTp3NusGkObc9UeW-Nm78K8_nsWSnnfg%40mail.gmail.com
> before I added the crashing tests).

I committed patches 0001 through 0003 (squashed).

I think I was mistaken about the need for an executor check (patch 
0004).  But we can add it on if a need appears.






view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Fix null pointer dereference in PG19
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox