pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Ants Aasma <ants.aasma@eesti.ee>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: WIP: Faster Expression Processing v4
Date: Mon, 27 Mar 2017 12:18:37 -0400
Message-ID: <32160.1490631517@sss.pgh.pa.us> (raw )
In-Reply-To: <31039.1490629925@sss.pgh.pa.us >
References: <5768.1490458935@sss.pgh.pa.us >
<20170325222202.uz6evsjqrtwjnql6@alap3.anarazel.de >
<CA+CSw_uq4OeY7i5u7=XeXXpJa0dMjfztP6FXrxQct-u=9vXJLA@mail.gmail.com >
<3CC5B4C5-3ADB-4296-A04B-64F594A4CE4F@anarazel.de >
<23529.1490500305@sss.pgh.pa.us >
<20170326035927.5mubkfdtaqlrgm2d@alap3.anarazel.de >
<20170327054314.qo6xsnlk7jcb7u2c@alap3.anarazel.de >
<15684.1490621623@sss.pgh.pa.us >
<20170327151750.dnpxtkjjade7kiv6@alap3.anarazel.de >
<19784.1490628160@sss.pgh.pa.us >
<20170327152914.m3firc6rkx5tqtgo@alap3.anarazel.de >
<31039.1490629925@sss.pgh.pa.us >
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
I wrote:
> As to the point of whether it actually helps or not ...
> on gcc 4.4.7 (RHEL 6), it makes things *WORSE*. We go from about half of
> the dispatches getting routed through a common location, to *all* of them
> (except one; for some odd reason the first EEO_NEXT in EEOP_NULLIF
> survives as a separate jump). This seems like a bug, but there it is.
So after a bit of googling, this is a very longstanding complaint:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=39284
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71785
(hm, think I know the second submitter)
I'm not sure we should be relying on a gcc bug fix that's barely four
months old. Even assuming it fixes the issue without new regressions,
most people are not going to have it anytime soon.
My feeling at this point is that we might be better off disabling
the computed-goto case by default. At the very least, we're going
to need a version check that restricts it to latest gcc.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
view thread (107+ messages) latest in thread
Message-ID: <32160.1490631517@sss.pgh.pa.us>
Permalink: ../32160.1490631517@sss.pgh.pa.us/
Also on: postgresql.org/message-id/32160.1490631517@sss.pgh.pa.us
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, ants.aasma@eesti.ee, hlinnaka@iki.fi, tomas.vondra@2ndquadrant.com
Subject: Re: WIP: Faster Expression Processing v4
In-Reply-To: <32160.1490631517@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox