pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Joel Jacobson <joel@compiler.org>
Subject: Re: Another regexp performance improvement: skip useless paren-captures
Date: Sun, 08 Aug 2021 18:28:13 -0400
Message-ID: <3289730.1628461693@sss.pgh.pa.us> (raw)
In-Reply-To: <D6AF940F-C48A-4666-A6E0-B92FC96F0711@enterprisedb.com>
References: <2219936.1628115334@sss.pgh.pa.us>
	<31908a04-f73b-8c5b-ed99-919fd4cd4b54@dunslane.net>
	<2390507.1628174181@sss.pgh.pa.us>
	<2BFE7DFD-8537-4B4E-BC4C-2F265A836651@enterprisedb.com>
	<3173384.1628442278@sss.pgh.pa.us>
	<BDB634FD-2EE5-4697-91A0-1F53E1363D3B@enterprisedb.com>
	<3224306.1628454300@sss.pgh.pa.us>
	<D6AF940F-C48A-4666-A6E0-B92FC96F0711@enterprisedb.com>

Mark Dilger <mark.dilger@enterprisedb.com> writes:
> I have applied your latest patch and do not see any problems with it.  All my tests pass with no asserts and with no differences in results vs. master.  This is a test suite of nearly 1.5 million separate regular expressions.

Cool, thanks.  I also tried your millions-of-random-regexps script
and didn't find any difference between the results from HEAD and
those from the v3 patch.

			regards, tom lane





view thread (31+ messages)  latest in thread

Message-ID: <3289730.1628461693@sss.pgh.pa.us>
Permalink:  ../3289730.1628461693@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3289730.1628461693@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, mark.dilger@enterprisedb.com, andrew@dunslane.net, pgsql-hackers@lists.postgresql.org, joel@compiler.org
  Subject: Re: Another regexp performance improvement: skip useless paren-captures
  In-Reply-To: <3289730.1628461693@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox