From: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] Tab completion for ALTER TABLE … ADD …
Date: Tue, 31 Aug 2021 09:36:48 +0100
Message-ID: <331beb60-5d58-48a1-b602-3c5f2043ff59@www.fastmail.com> (raw)
In-Reply-To: <YS2f7jpBkAmkFx+H@paquier.xyz>
References: <87bl6ehhpl.fsf@wibble.ilmari.org>
<YShkMBE3sq8mDa1S@paquier.xyz>
<87k0k7upla.fsf@wibble.ilmari.org>
<YSwsmd44F3tjFyLI@paquier.xyz>
<87h7f7uk6s.fsf@wibble.ilmari.org>
<YS2f7jpBkAmkFx+H@paquier.xyz>
On Tue, 31 Aug 2021, at 04:20, Michael Paquier wrote:
> On Mon, Aug 30, 2021 at 02:38:19PM +0100, Dagfinn Ilmari Mannsåker wrote:
> > That was because I forgot to exclude all the other object types that can
> > come after ADD. Attached is a patch that does that. I also moved it
> > right next to the ALTER TABLE … ADD completion, and added a comment to
> > keep the two lists in sync.
>
> Looks fine to me, so applied while we are on it.
Thanks!
- ilmari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ilmari@ilmari.org, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] Tab completion for ALTER TABLE … ADD …
In-Reply-To: <331beb60-5d58-48a1-b602-3c5f2043ff59@www.fastmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox