From: Michael Paquier <michael@paquier.xyz>
To: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] Tab completion for ALTER TABLE … ADD …
Date: Mon, 30 Aug 2021 09:55:53 +0900
Message-ID: <YSwsmd44F3tjFyLI@paquier.xyz> (raw)
In-Reply-To: <87k0k7upla.fsf@wibble.ilmari.org>
References: <87bl6ehhpl.fsf@wibble.ilmari.org>
<YShkMBE3sq8mDa1S@paquier.xyz>
<87k0k7upla.fsf@wibble.ilmari.org>
On Fri, Aug 27, 2021 at 11:52:33AM +0100, Dagfinn Ilmari Mannsåker wrote:
> That was easy enough to add (just a bit of extra fiddling to handle
> COLUMN being optional), done in the attached v2 patch.
This part was a bit misleading, as it would recommend a list of types
when specifying just ADD CONSTRAINT for example, so I have removed
it. An extra thing that felt a bit overdoing is the addition of KEY
after PRIMARY/FOREIGN.
> Doing a list of arbitrarily many comma-separated names is more
> complicated, so that can be the subject for another patch.
No objections to that. I have applied what we have now, as that's
already an improvement.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, ilmari@ilmari.org, pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] Tab completion for ALTER TABLE … ADD …
In-Reply-To: <YSwsmd44F3tjFyLI@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox