pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Drouvot, Bertrand <bdrouvot@amazon.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Joe Conway <mail@joeconway.com>
Cc: Jacob Champion <jchampion@timescale.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: sfrost@snowman.net <sfrost@snowman.net>
Cc: rjuju123@gmail.com <rjuju123@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: andres@anarazel.de <andres@anarazel.de>
Subject: Re: [PATCH] Expose port->authn_id to extensions and triggers
Date: Tue, 9 Aug 2022 12:39:02 +0200
Message-ID: <34308245-ea21-82ee-b1fd-00b4766f3527@amazon.com> (raw)
In-Reply-To: <YvImQ0sl1dV4TBNg@paquier.xyz>
References: <CAAWbhmhfzt+hYiTXi3f0V_E5E+E_mmzd_x+p9zjs_NvBpJ36pA@mail.gmail.com>
	<CA+TgmoZmRAkOgNzSqRxzJ=Kok_NYHZ57X2ZKRh=cfoCukp4f_Q@mail.gmail.com>
	<CAAWbhmjPu2VNS8MhwDp=+hu61EsJ3zf_rTRtyZ8Qw08eAhg_pA@mail.gmail.com>
	<f98e0b81-96cb-b0d8-c483-e99563cc44b4@amazon.com>
	<3b678314-054a-6119-b373-4574067f404e@timescale.com>
	<cc8aaffb-1008-eaf6-090e-2461cbe6e1cf@amazon.com>
	<Yu4JhEvh1V0sGWXv@paquier.xyz>
	<af85ae52-de60-6a98-d69e-7d410aee752d@joeconway.com>
	<Yu9slCBp0WWD4Qx1@paquier.xyz>
	<d25a412e-9686-d37f-3bd1-63b821f67a51@amazon.com>
	<YvImQ0sl1dV4TBNg@paquier.xyz>

Hi,

On 8/9/22 11:17 AM, Michael Paquier wrote:
> On Mon, Aug 08, 2022 at 12:43:14PM +0200, Drouvot, Bertrand wrote:
>> but I'm not sure we should do it as a first step (given the fact that this
>> is not Port->authn_id that is passed down to the parallel workers in the
>> SYSTEM_USER patch).
>>
>> What do you think about working on both (aka a) v11-002 only
>> ClientConnectionInfo and b) SYSTEM_USER) in parallel?
> It seems to me that completing ClientConnectionInfo first has the
> advantage of not having to tweak twice the interface we are going to
> use when passing down the full structure to the workers, so I would
> choose for doing it first (with one field for the authn, and a second
> field for the auth method so as the the workers can build SYSTEM_USER
> by themselves when required).

Yeah fair point.

Agree that it makes sense to work on those patches in this particular 
order then.

Thanks,

-- 

Bertrand Drouvot
Amazon Web Services: https://aws.amazon.com






view thread (89+ messages)  latest in thread

Message-ID: <34308245-ea21-82ee-b1fd-00b4766f3527@amazon.com>
Permalink:  ../34308245-ea21-82ee-b1fd-00b4766f3527@amazon.com/
Also on:    postgresql.org/message-id/34308245-ea21-82ee-b1fd-00b4766f3527@amazon.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: bdrouvot@amazon.com, michael@paquier.xyz, mail@joeconway.com, jchampion@timescale.com, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, sfrost@snowman.net, rjuju123@gmail.com, andres@anarazel.de
  Subject: Re: [PATCH] Expose port->authn_id to extensions and triggers
  In-Reply-To: <34308245-ea21-82ee-b1fd-00b4766f3527@amazon.com>
  References: <CAAWbhmhfzt+hYiTXi3f0V_E5E+E_mmzd_x+p9zjs_NvBpJ36pA@mail.gmail.com> <CA+TgmoZmRAkOgNzSqRxzJ=Kok_NYHZ57X2ZKRh=cfoCukp4f_Q@mail.gmail.com> <CAAWbhmjPu2VNS8MhwDp=+hu61EsJ3zf_rTRtyZ8Qw08eAhg_pA@mail.gmail.com> <f98e0b81-96cb-b0d8-c483-e99563cc44b4@amazon.com> <3b678314-054a-6119-b373-4574067f404e@timescale.com> <cc8aaffb-1008-eaf6-090e-2461cbe6e1cf@amazon.com> <Yu4JhEvh1V0sGWXv@paquier.xyz> <af85ae52-de60-6a98-d69e-7d410aee752d@joeconway.com> <Yu9slCBp0WWD4Qx1@paquier.xyz> <d25a412e-9686-d37f-3bd1-63b821f67a51@amazon.com> <YvImQ0sl1dV4TBNg@paquier.xyz> <34308245-ea21-82ee-b1fd-00b4766f3527@amazon.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox