From: Tom Lane <tgl@sss.pgh.pa.us>
To: John Naylor <john.naylor@enterprisedb.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Erik Rijkers <er@xs4all.nl>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: fix typos
Date: Thu, 04 Aug 2022 09:41:05 -0400
Message-ID: <3437166.1659620465@sss.pgh.pa.us> (raw)
In-Reply-To: <CAFBsxsGeWFdz0kTWDN5HU4qhBJdJjU+aDookfofha80rqvieMA@mail.gmail.com>
References: <b79bfeff-d0e3-29a3-2576-0e325848dede@xs4all.nl>
<20220801181136.GJ15006@telsasoft.com>
<CAFBsxsGeWFdz0kTWDN5HU4qhBJdJjU+aDookfofha80rqvieMA@mail.gmail.com>
John Naylor <john.naylor@enterprisedb.com> writes:
> On Tue, Aug 2, 2022 at 1:11 AM Justin Pryzby <pryzby@telsasoft.com> wrote:
> ereport(ERROR,
> (errcode(ERRCODE_OBJECT_IN_USE),
> - errmsg("could not drop replication origin with OID %d, in use by PID %d",
> + errmsg("could not drop replication origin with OID %u, in use by PID %d",
> RepOriginId is a typedef for uint16, so this can't print the wrong answer,
> but it is inconsistent with other uses. So it seems we don't need to
> backpatch this one?
Um ... if it's int16, then it can't be an OID, so I'd say this message has
far worse problems than %d vs %u. It should not use that terminology.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, john.naylor@enterprisedb.com, pryzby@telsasoft.com, er@xs4all.nl, pgsql-hackers@lists.postgresql.org
Subject: Re: fix typos
In-Reply-To: <3437166.1659620465@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox