pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Tom Lane <tgl@sss.pgh.pa.us>
To: vignesh C <vignesh21@gmail.com>
Cc: Eric Radman <ericshane@eradman.com>
Cc: Dag Lem <dag@nimrod.no>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] Add function to_oct
Date: Sat, 07 Jan 2023 10:29:49 -0500
Message-ID: <3448478.1673105389@sss.pgh.pa.us> (raw)
In-Reply-To: <CALDaNm1MvZ39UziVoLMZhFjgS1F9+zJ_oKF9icO-aeK02jRb9g@mail.gmail.com>
References: <Y6IyTQQ/TsD5wnsH@vm3.eradman.com>
	<CAB8KJ=g4kbRPAPLq9jwKQbzqG8tX4gFAc2rFgz-SKjUzJ7PsFQ@mail.gmail.com>
	<167170369754.1121.7881078512513671914.pgcf@coridan.postgresql.org>
	<Y6SWxEM92Pbqs0l/@vm3.eradman.com>
	<CALDaNm1MvZ39UziVoLMZhFjgS1F9+zJ_oKF9icO-aeK02jRb9g@mail.gmail.com>

vignesh C <vignesh21@gmail.com> writes:
> Few suggestions
> 1) We could use to_oct instead of to_oct32 as we don't have multiple
> implementations for to_oct

That seems (a) shortsighted and (b) inconsistent with the naming
pattern used for to_hex, so I doubt it'd be an improvement.

			regards, tom lane

view thread (34+ messages)  latest in thread

Message-ID: <3448478.1673105389@sss.pgh.pa.us>
Permalink:  ../3448478.1673105389@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3448478.1673105389@sss.pgh.pa.us

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, vignesh21@gmail.com, ericshane@eradman.com, dag@nimrod.no, pgsql-hackers@lists.postgresql.org
  Subject: Re: [PATCH] Add function to_oct
  In-Reply-To: <3448478.1673105389@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox