From: Pavlo Golub <pavlo.golub@cybertec.at>
To: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Craig Ringer <craig@2ndquadrant.com>
Subject: ReplicationSlotCtl: undefined reference
Date: Tue, 11 Jun 2019 15:19:43 +0300
Message-ID: <345138875.20190611151943@cybertec.at> (raw)
Greetings.
Trying to build pg extension I've got error:
```
pglogical_monitoring.o:pglogical_monitoring.c:(.rdata$.refptr.ReplicationSlotCtl[.refptr.ReplicationSlotCtl]+0x0): undefined reference to `ReplicationSlotCtl'
collect2: error: ld returned 1 exit status
```
But according to https://commitfest.postgresql.org/16/1390/ it should
be marked with PGDLLIMPORT.
However checking sources there is no this spec
(https://github.com/postgres/postgres/blob/fff2a7d7bd09db38e1bafc1303c29b10a9805dc0/src/include/repli...):
```
extern ReplicationSlotCtlData *ReplicationSlotCtl;
```
Am I correct or missing smth?
Craig, it supposed to be your proposal about ReplicationSlotCtl and
patch. Am I right?
--
Kind regards,
Pavlo mailto:pavlo.golub@cybertec.at
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pavlo.golub@cybertec.at, craig@2ndquadrant.com
Subject: Re: ReplicationSlotCtl: undefined reference
In-Reply-To: <345138875.20190611151943@cybertec.at>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox