From: Tom Lane <tgl@sss.pgh.pa.us>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: allow to \dtS+ pg_toast.*
Date: Tue, 05 Jan 2021 18:46:01 -0500
Message-ID: <3454491.1609890361@sss.pgh.pa.us> (raw)
In-Reply-To: <75f515dda92a7576f18baf872ed7e45ca03db160.camel@cybertec.at>
References: <20201130165436.GX24052@telsasoft.com>
<1839fe7148f3aa1a7b28da9064a5c2f8b08316c3.camel@cybertec.at>
<20201218065808.GY30237@telsasoft.com>
<c3fdffcfd26f4d433307fa80f6ef7f0b3b183f06.camel@cybertec.at>
<20201218173312.GZ30237@telsasoft.com>
<75f515dda92a7576f18baf872ed7e45ca03db160.camel@cybertec.at>
Laurenz Albe <laurenz.albe@cybertec.at> writes:
> On Fri, 2020-12-18 at 11:33 -0600, Justin Pryzby wrote:
>>>> This makes toast tables a bit less special and easier to inspect.
Pushed, except for
>>> Another thing that is missing is tab completion for
>>> regression=# \dtS pg_toast.pg_
>>> This should work just like for \d and \dS.
>> I agree that it's nice to complete the schema name, but I'm still not convinced
>> this part should be included.
> Again a judgement call. I am happy with the way the latest patch does it.
I remain pretty much against including toast tables in tab completion,
so I left out that part.
>> I considered whether "toast table" should be capitalized (as it is for "\d")
>> but I think it should stay lowercase.
> Then you should also change the way \d does it (upper case).
> I think we should be consistent.
I think capitalized TOAST is correct, because it's an acronym.
I also agree that consistency with what \d shows is important,
and I have no desire to change \d's longstanding output.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, laurenz.albe@cybertec.at, pryzby@telsasoft.com
Subject: Re: allow to \dtS+ pg_toast.*
In-Reply-To: <3454491.1609890361@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox