From: Tom Lane <tgl@sss.pgh.pa.us>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Kirk Wolak <wolakk@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: psql: Could we get "-- " prefixing on the **** QUERY **** outputs? (ECHO_HIDDEN)
Date: Wed, 17 May 2023 14:13:30 -0400
Message-ID: <3509103.1684347210@sss.pgh.pa.us> (raw)
In-Reply-To: <b3b2ae6061c0d80fb29fe36482849e9171c3f659.camel@cybertec.at>
References: <20230515141457.ovpznndsvulahbpk@alvherre.pgsql>
<2153025.1684160932@sss.pgh.pa.us>
<CACLU5mSYSC-7waxNE0bsrph7QW9Bq9Dw5M26swmQ6x6iSd1tdQ@mail.gmail.com>
<CACLU5mRhBiYjh-Cq7yvnGUA3VqX44Gh3QFkzmViP4ZNjdiJ7mw@mail.gmail.com>
<b3b2ae6061c0d80fb29fe36482849e9171c3f659.camel@cybertec.at>
Laurenz Albe <laurenz.albe@cybertec.at> writes:
> You removed the ******** QUERY ******** at the end of the query.
> I think we should keep that (as comments, of course). People
> are used to the current output, and it is nice to have a clear
> visual marker at the end of what isn't normally part of "psql"
> output.
I agree. These considerations of what shows up in the readline
log if you choose to copy-and-paste seem far secondary to the
readability of the terminal output in the first place.
Also, you'd have to avoid copying-and-pasting the query output
anyway, so I'm not entirely sold that there's much of
a usability gain here.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, laurenz.albe@cybertec.at, wolakk@gmail.com, alvherre@alvh.no-ip.org, pavel.stehule@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: psql: Could we get "-- " prefixing on the **** QUERY **** outputs? (ECHO_HIDDEN)
In-Reply-To: <3509103.1684347210@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox