pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: David E. Wheeler <david@justatheory.com>
Cc: Mankirat Singh <mankiratsingh1315@gmail.com>
Cc: pg@bowt.ie
Cc: andrew@dunslane.net
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()
Date: Mon, 20 Oct 2025 15:33:53 -0400
Message-ID: <351026.1760988833@sss.pgh.pa.us> (raw)
In-Reply-To: <aPZ_2a1EQvofxeci@nathan>
References: <78B81B37-9F27-4085-92DA-6B50DFC24361@justatheory.com>
	<CAOtk82QCHhWwO=zB-KFYch3JLf8Si4Bk77R_0cgsHjkwuhR9Vg@mail.gmail.com>
	<1957147.1760800489@sss.pgh.pa.us>
	<17DB0A6A-C967-48A8-B1C0-9A4F31C4F8EF@justatheory.com>
	<CAOtk82T=OO3e=SYPyHZq50wfyt569E6t=ee4b7va2y08M+a0SQ@mail.gmail.com>
	<F6567E02-23FD-455C-95D2-5CB076BC4E65@justatheory.com>
	<230647.1760971159@sss.pgh.pa.us>
	<aPZnY0Icgw1RGaGP@nathan>
	<334460.1760980024@sss.pgh.pa.us>
	<aPZt4b5beRPxjgI-@nathan>
	<aPZ_2a1EQvofxeci@nathan>

Nathan Bossart <nathandbossart@gmail.com> writes:
> Here is an updated patch set.

The v3 patches work for me.

BTW, not critical right now, but thought I'd mention it: ISTM
this mechanism obviates the need for the single-purpose NodeTag ABI
checks installed by commit eea9fa9b2.  We still need the checks in
gen_node_support.pl to ensure that the makefiles and meson files
build things the same way, but we shouldn't need the parts that were
intended to prevent accidental ABI changes in the back branches.
Since that stuff requires nonzero manual maintenance, I plan to get
rid of it once we're satisfied that the ABI checker is working well.

			regards, tom lane





view thread (70+ messages)  latest in thread

Message-ID: <351026.1760988833@sss.pgh.pa.us>
Permalink:  ../351026.1760988833@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/351026.1760988833@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, nathandbossart@gmail.com, david@justatheory.com, mankiratsingh1315@gmail.com, pg@bowt.ie, andrew@dunslane.net, pgsql-hackers@lists.postgresql.org
  Subject: Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()
  In-Reply-To: <351026.1760988833@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox