From: a.kondratov@postgrespro.ru
To: Laurenz Albe <laurenz.albe@cybertec.at>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Paul Guo <pguo@pivotal.io>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Jimmy Yih <jyih@pivotal.io>
Cc: Ashwin Agrawal <aagrawal@pivotal.io>
Subject: Re: Two pg_rewind patches (auto generate recovery conf and ensure clean shutdown)
Date: Wed, 25 Sep 2019 23:22:35 +0300
Message-ID: <3524fc417c6e25574e2bdedf5f7bf09d@postgrespro.ru> (raw)
In-Reply-To: <5d8f802d0cc1871ac4bd9450ba98ce8d0626bb58.camel@cybertec.at>
References: <20190925174812.GA4916@alvherre.pgsql>
<5d8f802d0cc1871ac4bd9450ba98ce8d0626bb58.camel@cybertec.at>
On 2019-09-25 20:48, Alvaro Herrera wrote:
> CC Alexey for reasons that become clear below.
>
> Another thing in 0002 is that you're adding a "-R" switch to pg_rewind,
> but we have another patch in the commitfest using the same switch for a
> different purpose. Maybe you guys need to get to an agreement over who
> uses the letter :-)
>
Thank you for mentioning me. I've been monitoring silently this thread
and was ready to modify my patch if this one will proceed faster. It
seems like it's time :)
On 2019-09-25 22:26, Laurenz Albe wrote:
>
> I believe that -R should be reserved for creating recovery.conf,
> similar to pg_basebackup.
>
> Everything else would be confusing.
>
> I've been missing pg_rewind -R!
>
Yes, -R is already used in pg_basebackup for the same functionality, so
it seems natural to use it here as well for consistency.
I will review options naming in my own patch and update it accordingly.
Maybe -w/-W or -a/-A options will be good, since it's about WALs
retrieval from archive.
Regards
--
Alexey
P.S. Just noticed that in v12 fullname of -R option in pg_basebackup is
still --write-recovery-conf, which is good for a backward compatibility,
but looks a little bit awkward, since recovery.conf doesn't exist
already, doesn't it? However, one may read it as
'write-recovery-configuration', then it seems fine.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: a.kondratov@postgrespro.ru, laurenz.albe@cybertec.at, alvherre@2ndquadrant.com, pguo@pivotal.io, michael@paquier.xyz, thomas.munro@gmail.com, jyih@pivotal.io, aagrawal@pivotal.io
Subject: Re: Two pg_rewind patches (auto generate recovery conf and ensure clean shutdown)
In-Reply-To: <3524fc417c6e25574e2bdedf5f7bf09d@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox